fix: fixed visibility of jsi object in PeriodicWave

software-mansion-labs · Dec 13, 2024 · 427eeb3 · 427eeb3
1 parent 5cf240b
commit 427eeb3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/packages/react-native-audio-api/common/cpp/core/AudioScheduledSourceNode.h b/packages/react-native-audio-api/common/cpp/core/AudioScheduledSourceNode.h
@@ -1,13 +1,13 @@
 #pragma once
 
+#include <algorithm>
 #include <atomic>
 #include <chrono>
 #include <functional>
 #include <iostream>
+#include <limits>
 #include <memory>
 #include <thread>
-#include <limits>
-#include <algorithm>
 
 #include "AudioNode.h"
 

diff --git a/packages/react-native-audio-api/common/cpp/jsi/JsiHostObject.cpp b/packages/react-native-audio-api/common/cpp/jsi/JsiHostObject.cpp
@@ -12,8 +12,6 @@ JsiHostObject::JsiHostObject() {
   propertySetters_ = std::make_unique<std::unordered_map<
       std::string,
       void (JsiHostObject::*)(jsi::Runtime &, const jsi::Value &)>>();
-
-  propertyGetters_->insert(JSI_EXPORT_PROPERTY_GETTER(JsiHostObject, then));
 }
 
 std::vector<jsi::PropNameID> JsiHostObject::getPropertyNames(jsi::Runtime &rt) {

diff --git a/packages/react-native-audio-api/common/cpp/jsi/JsiHostObject.h b/packages/react-native-audio-api/common/cpp/jsi/JsiHostObject.h
@@ -2,10 +2,10 @@
 
 #include <jsi/jsi.h>
 #include <memory>
+#include <string>
 #include <unordered_map>
 #include <utility>
 #include <vector>
-#include <string>
 
 #define JSI_HOST_FUNCTION(NAME)  \
   jsi::Value NAME(               \
@@ -70,10 +70,6 @@ class JsiHostObject : public jsi::HostObject {
     (propertyFunctions_->insert(args), ...);
   }
 
-  JSI_PROPERTY_GETTER(then) {
-    return jsi::Value::undefined();
-  }
-
  protected:
   std::unique_ptr<std::unordered_map<
       std::string,

diff --git a/packages/react-native-audio-api/src/index.ts b/packages/react-native-audio-api/src/index.ts
@@ -294,6 +294,7 @@ export class BiquadFilterNode extends AudioNode {
 }
 
 export class PeriodicWave {
+  /** @internal */
   readonly periodicWave: globalThis.PeriodicWave;
 
   constructor(periodicWave: globalThis.PeriodicWave) {