Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch more generic exceptions for InstallReferrer (close #647) #681

Merged
merged 6 commits into from
Apr 5, 2024
Merged

Catch more generic exceptions for InstallReferrer (close #647) #681

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd85288
Catch more errors
mscwilson Mar 28, 2024
d878626
Give more detailed error message
mscwilson Mar 28, 2024
7a56a1e
Restore installreferrer version
mscwilson Mar 28, 2024
19102d2
Increase sleep time in flaky tests
mscwilson Apr 4, 2024
9c2417c
Increase sleep time in flaky tests again
mscwilson Apr 4, 2024
6d79c99
Increase sleep time in flaky tests again... again
mscwilson Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions snowplow-tracker/src/main/java/com/snowplowanalytics/core/tracker/InstallReferrerDetails.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
package com.snowplowanalytics.core.tracker

import android.content.Context
import android.os.RemoteException
import com.android.installreferrer.api.InstallReferrerClient
import com.android.installreferrer.api.InstallReferrerStateListener
import com.android.installreferrer.api.InstallReferrerClient.InstallReferrerResponse
Expand Down Expand Up @@ -72,7 +71,7 @@ class InstallReferrerDetails(
googlePlayInstantParam = response.googlePlayInstantParam
)
callback(referrer)
} catch (_: RemoteException) {
} catch (_: Throwable) {
mscwilson marked this conversation as resolved.
Show resolved Hide resolved
Logger.d(TAG, "Install referrer API remote exception.")
callback(null)
}
Expand All @@ -99,7 +98,7 @@ class InstallReferrerDetails(
})
}

fun isInstallReferrerPackageAvailable(): Boolean {
private fun isInstallReferrerPackageAvailable(): Boolean {
try {
Class.forName("com.android.installreferrer.api.InstallReferrerStateListener")
return true
Expand Down
Loading