Catch more generic exceptions for InstallReferrer (close #647)

* Catch more errors * Give more detailed error message * Restore installreferrer version * Increase sleep time in flaky tests * Increase sleep time in flaky tests again * Increase sleep time in flaky tests again... again
snowplow · Apr 5, 2024 · 55f5656 · 55f5656
1 parent c1be49c
commit 55f5656
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 39 deletions.
diff --git a/.../src/androidTest/java/com/snowplowanalytics/snowplow/event/ApplicationInstallEventTest.kt b/.../src/androidTest/java/com/snowplowanalytics/snowplow/event/ApplicationInstallEventTest.kt
@@ -49,7 +49,7 @@ class ApplicationInstallEventTest {
             .installAutotracking(true)
         createTracker(listOf(trackerConfiguration, plugin))
 
-        Thread.sleep(1000)
+        Thread.sleep(1500)
 
         // check if event was tracked
         Assert.assertTrue(eventTracked)
@@ -67,7 +67,7 @@ class ApplicationInstallEventTest {
             .installAutotracking(true)
         createTracker(listOf(trackerConfiguration, plugin))
 
-        Thread.sleep(1000)
+        Thread.sleep(1500)
 
         // check if event was tracked
         Assert.assertTrue(eventTracked)
@@ -78,7 +78,7 @@ class ApplicationInstallEventTest {
         // create tracker again
         createTracker(listOf(trackerConfiguration, plugin))
 
-        Thread.sleep(1000)
+        Thread.sleep(1500)
 
         // check if event was tracked
         Assert.assertFalse(eventTracked)

diff --git a/...-tracker/src/androidTest/java/com/snowplowanalytics/snowplow/media/TestMediaController.kt b/...-tracker/src/androidTest/java/com/snowplowanalytics/snowplow/media/TestMediaController.kt
@@ -87,7 +87,7 @@ class TestMediaController {
         )
         media?.track(MediaPlayEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(1, trackedEvents.size)
         assertEquals(eventSchema("play"), firstEvent.schema)
@@ -102,7 +102,7 @@ class TestMediaController {
         )
         media?.track(MediaEndEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(1, trackedEvents.size)
         assertEquals(eventSchema("end"), firstEvent.schema)
@@ -119,7 +119,7 @@ class TestMediaController {
         media?.track(event = MediaSeekEndEvent(), player = MediaPlayerEntity(currentTime = 2.0))
         media?.track(event = MediaSeekStartEvent(), player = MediaPlayerEntity(currentTime = 3.0))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(3, trackedEvents.size)
         assertEquals(2, trackedEvents.filter { it.schema == eventSchema("seek_start") }.size)
@@ -136,7 +136,7 @@ class TestMediaController {
         media?.track(MediaPlayEvent())
         media?.track(MediaPauseEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(1, trackedEvents.size)
         assertEquals(eventSchema("play"), firstEvent.schema)
@@ -154,7 +154,7 @@ class TestMediaController {
 
         media?.track(MediaPlayEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(1, trackedEvents.size)
         assertNotNull(
@@ -178,7 +178,7 @@ class TestMediaController {
                 )
         )
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(1, trackedEvents.size)
         assertNotNull(
@@ -199,7 +199,7 @@ class TestMediaController {
         media?.track(MediaPlaybackRateChangeEvent(newRate = 1.5))
         media?.track(MediaPauseEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(2, trackedEvents.size)
         val rateEvent = trackedEvents.find { it.schema == eventSchema("playback_rate_change") }
@@ -238,7 +238,7 @@ class TestMediaController {
 
         media?.track(MediaFullscreenChangeEvent(fullscreen = true))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(true, firstEvent.payload.get("fullscreen"))
         assertEquals(true, firstPlayer?.get("fullscreen"))
@@ -253,7 +253,7 @@ class TestMediaController {
 
         media?.track(MediaPictureInPictureChangeEvent(pictureInPicture = true))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(true, firstEvent.payload.get("pictureInPicture"))
         assertEquals(true, firstPlayer?.get("pictureInPicture"))
@@ -265,7 +265,7 @@ class TestMediaController {
 
         media?.track(MediaAdFirstQuartileEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(25, firstEvent.payload.get("percentProgress"))
     }
@@ -276,7 +276,7 @@ class TestMediaController {
 
         media?.track(MediaAdMidpointEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(50, firstEvent.payload.get("percentProgress"))
     }
@@ -287,7 +287,7 @@ class TestMediaController {
 
         media?.track(MediaAdThirdQuartileEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(75, firstEvent.payload.get("percentProgress"))
     }
@@ -301,7 +301,7 @@ class TestMediaController {
         media?.track(MediaAdResumeEvent(percentProgress = 40))
         media?.track(MediaAdPauseEvent(percentProgress = 50))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         val adClickEvent = trackedEvents.find { it.schema == eventSchema("ad_click") }
         assertEquals(15, adClickEvent?.payload?.get("percentProgress"))
@@ -326,7 +326,7 @@ class TestMediaController {
             framesPerSecond = 60
         ))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals("720p", firstEvent.payload.get("previousQuality"))
         assertEquals("1080p", firstEvent.payload.get("newQuality"))
@@ -344,7 +344,7 @@ class TestMediaController {
             errorDescription = "Failed to load media"
         ))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals("501", firstEvent.payload.get("errorCode"))
         assertEquals("forbidden", firstEvent.payload.get("errorName"))
@@ -363,7 +363,7 @@ class TestMediaController {
             mapOf("url" to "https://www.youtube.com/watch?v=12345")
         ))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals("iglu:com.acme/video_played/jsonschema/1-0-0", firstEvent.schema)
         assertEquals("Video", firstPlayer?.get("label"))
@@ -377,7 +377,7 @@ class TestMediaController {
 
         media?.track(MediaPlayEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals("media1", firstSession?.get("mediaSessionId"))
     }
@@ -401,7 +401,7 @@ class TestMediaController {
         media.update(player = MediaPlayerEntity(currentTime = 10.0))
         media.track(MediaEndEvent())
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         val endEvent = trackedEvents.find { it.schema == eventSchema("end") }
         val lastSession = endEvent?.entities?.find { it.map.get("schema") == sessionSchema }?.map?.get("data") as? Map<*, *>
@@ -427,7 +427,7 @@ class TestMediaController {
 
         timer.fire()
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(1, trackedEvents.size)
         assertEquals(10000L, timer.delay)
@@ -452,7 +452,7 @@ class TestMediaController {
         media.track(MediaPauseEvent())
         timer.fire()
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(4, trackedEvents.size)
     }
@@ -475,7 +475,7 @@ class TestMediaController {
             timer.fire()
         }
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(2, trackedEvents.size)
     }
@@ -498,7 +498,7 @@ class TestMediaController {
             timer.fire()
         }
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(5, trackedEvents.size)
     }
@@ -519,7 +519,7 @@ class TestMediaController {
             media?.update(player = MediaPlayerEntity(currentTime = i.toDouble()))
         }
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(4, trackedEvents.size)
         assertEquals(3, trackedEvents.filter { it.schema == eventSchema("percent_progress") }.size)
@@ -539,7 +539,7 @@ class TestMediaController {
             media?.update(player = MediaPlayerEntity(currentTime = i.toDouble()))
         }
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(2, trackedEvents.size)
 
@@ -562,7 +562,7 @@ class TestMediaController {
             media?.update(player = MediaPlayerEntity(currentTime = i.toDouble()))
         }
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(1, trackedEvents.size)
     }
@@ -586,7 +586,7 @@ class TestMediaController {
             media?.update(player = MediaPlayerEntity(currentTime = i.toDouble()))
         }
 
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         assertEquals(5, trackedEvents.size)
         assertEquals(3, trackedEvents.filter { it.schema == eventSchema("percent_progress") }.size)

diff --git a/snowplow-tracker/src/androidTest/java/com/snowplowanalytics/snowplow/tracker/PluginsTest.kt b/snowplow-tracker/src/androidTest/java/com/snowplowanalytics/snowplow/tracker/PluginsTest.kt
@@ -62,7 +62,7 @@ class PluginsTest {
         val tracker = createTracker(listOf(plugin, testPlugin))
         tracker.track(Structured("cat", "act"))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
         Assert.assertTrue(expectation)
     }
 
@@ -84,7 +84,7 @@ class PluginsTest {
         val tracker = createTracker(listOf(plugin1, plugin2, testPlugin))
         tracker.track(ScreenView("sv"))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
         Assert.assertTrue(expectation)
     }
 
@@ -112,7 +112,7 @@ class PluginsTest {
         tracker.track(SelfDescribing("schema1", emptyMap()))
         tracker.track(SelfDescribing("schema2", emptyMap()))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
         Assert.assertTrue(event1HasEntity!!)
         Assert.assertFalse(event2HasEntity!!)
     }
@@ -135,7 +135,7 @@ class PluginsTest {
         tracker.track(SelfDescribing("schema2", emptyMap()))
         tracker.track(Structured("cat", "act"))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
         Assert.assertTrue(event1Called)
         Assert.assertFalse(event2Called)
         Assert.assertFalse(event3Called)
@@ -156,7 +156,7 @@ class PluginsTest {
         tracker.track(SelfDescribing("schema1", emptyMap()))
         tracker.track(Structured("cat", "act"))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
         Assert.assertTrue(structuredCalled)
         Assert.assertFalse(selfDescribingCalled)
     }
@@ -172,7 +172,7 @@ class PluginsTest {
 
         tracker.track(ScreenView("sv"))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
         Assert.assertTrue(expectation)
     }
 
@@ -187,7 +187,7 @@ class PluginsTest {
 
         tracker.track(ScreenView("sv"))
 
-        Thread.sleep(100)
+        Thread.sleep(200)
         Assert.assertFalse(pluginCalled)
     }
 
@@ -203,12 +203,12 @@ class PluginsTest {
         val tracker = createTracker(listOf(filterPlugin, afterTrackPlugin))
 
         tracker.track(SelfDescribing("s1", emptyMap()))
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         Assert.assertFalse(afterTrackCalled)
 
         tracker.track(SelfDescribing("s2", emptyMap()))
-        Thread.sleep(100)
+        Thread.sleep(200)
 
         Assert.assertTrue(afterTrackCalled)
     }

diff --git a/snowplow-tracker/src/main/java/com/snowplowanalytics/core/tracker/InstallReferrerDetails.kt b/snowplow-tracker/src/main/java/com/snowplowanalytics/core/tracker/InstallReferrerDetails.kt
@@ -75,6 +75,9 @@ class InstallReferrerDetails(
                             } catch (_: RemoteException) {
                                 Logger.d(TAG, "Install referrer API remote exception.")
                                 callback(null)
+                            } catch (_: NoSuchMethodError) {
+                                Logger.d(TAG, "Upgrade InstallReferrer package to v1.1 or higher to add the install referrer details entity.")
+                                callback(null)
                             }
                         }
                         InstallReferrerResponse.FEATURE_NOT_SUPPORTED -> {
@@ -99,7 +102,7 @@ class InstallReferrerDetails(
             })
         }
 
-        fun isInstallReferrerPackageAvailable(): Boolean {
+        private fun isInstallReferrerPackageAvailable(): Boolean {
             try {
                 Class.forName("com.android.installreferrer.api.InstallReferrerStateListener")
                 return true