Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run cargo update on the runtime lockfiles and the SDK lockfile #3928

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Run cargo update on the runtime lockfiles and the SDK lockfile #3928

merged 3 commits into from
Dec 5, 2024

Conversation

aws-sdk-rust-ci
Copy link
Collaborator

If CI fails, commit the necessary fixes to this PR until all checks pass.

If changes are required to crateNameToLastKnownWorkingVersions, revert the first commit in the PR, run ./gradlew aws:sdk:cargoUpdateAllLockfiles, and commit the updated lockfiles.

@aws-sdk-rust-ci aws-sdk-rust-ci requested a review from a team as a code owner December 3, 2024 22:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

A new generated diff is ready to view.

A new doc preview is ready to view.

@landonxjames
Copy link
Contributor

The failed server test is caused by the time crate being bumped:

[[package]]
name = "time"
version = "0.3.37"

The time crate loosened some of their parsing restrictions and that is causing some protocol tests to fail: time-rs/time#700

This was previously fixed by a9a69a5 copying the rust-runtime/Cargo.lock into the server tests. Since the version of time is now bumped in that lockfile that fix no longer works. @drganjoo is working on a more permanent fix for this so will likely wait on that before merging.

@drganjoo
Copy link
Contributor

drganjoo commented Dec 4, 2024

I've submitted a PR to enforce 'T' as the only allowed separator for date-time values: https://github.com/smithy-lang/smithy-rs/pull/3934/files

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

A new generated diff is ready to view.

A new doc preview is ready to view.

landonxjames
landonxjames approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@landonxjames landonxjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing Semver test is expected and should be fixed by the MSRV bump to 1.81.0 that is currently in PR

@landonxjames landonxjames added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 20ad770 Dec 5, 2024
43 of 44 checks passed
@landonxjames landonxjames deleted the update-all-lockfiles-1733263367 branch December 5, 2024 17:43
landonxjames added a commit that referenced this pull request Dec 5, 2024
@aws-sdk-rust-ci @landonxjames @ysaito1001
Run cargo update on the runtime lockfiles and the SDK lockfile (#3928)
24729bb 
If CI fails, commit the necessary fixes to this PR until all checks
pass.

If changes are required to
[crateNameToLastKnownWorkingVersions](https://github.com/smithy-lang/smithy-rs/blob/92916b5484cdfef9ff58540ebf5e845eeeccf860/aws/sdk/build.gradle.kts#L504),
revert the first commit in the PR, run `./gradlew
aws:sdk:cargoUpdateAllLockfiles`, and commit the updated lockfiles.

Co-authored-by: Landon James <[email protected]>
Co-authored-by: ysaito1001 <[email protected]>
landonxjames added a commit that referenced this pull request Dec 6, 2024
@aws-sdk-rust-ci @landonxjames @ysaito1001
Run cargo update on the runtime lockfiles and the SDK lockfile (#3928)
4f3f3c0 
If CI fails, commit the necessary fixes to this PR until all checks
pass.

If changes are required to
[crateNameToLastKnownWorkingVersions](https://github.com/smithy-lang/smithy-rs/blob/92916b5484cdfef9ff58540ebf5e845eeeccf860/aws/sdk/build.gradle.kts#L504),
revert the first commit in the PR, run `./gradlew
aws:sdk:cargoUpdateAllLockfiles`, and commit the updated lockfiles.

Co-authored-by: Landon James <[email protected]>
Co-authored-by: ysaito1001 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landonxjames landonxjames landonxjames approved these changes

Assignees
No one assigned
Labels
needs-sdk-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aws-sdk-rust-ci @landonxjames @drganjoo @ysaito1001