CCIP-4420 Moving ocr2/plugins/ccip from the CCIP repo

[mateusz-sekara]

Requires

Supports

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
24.6% Duplication on New Code (required ≤ 10%)
C Reliability Rating on New Code (required ≥ A)
10 New Major Issues (required ≤ 5)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (.) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , SonarQube Scan , lint

1. Missing required Go modules:go_core_race_tests

Source of Error:

core/services/ocr2/plugins/ccip/config/type_and_version.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/type_and_version_interface_wrapper; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/type_and_version_interface_wrapper
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/commit_store.go:25:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/commit_store_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/commit_store_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/offramp.go:30:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_offramp_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_offramp_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/hasher.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/price_registry.go:21:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/price_registry_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/price_registry_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_1_0/onramp.go:13:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_1_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_1_0
core/services/ocr2/plugins/ccip/internal/pricegetter/evm.go:16:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/aggregator_v3_interface; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/aggregator_v3_interface

Why: The Go build process is failing because several required modules are not provided. These modules are necessary for the build process to complete successfully.

Suggested fix: Run go get commands for each missing module to add them to the project. Ensure that the go.mod file is updated accordingly.

2. Missing required Go modules:go_core_tests_integration

Source of Error:

core/services/ocr2/plugins/ccip/config/type_and_version.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/type_and_version_interface_wrapper; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/type_and_version_interface_wrapper
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/commit_store.go:25:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/commit_store_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/commit_store_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/offramp.go:30:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_offramp_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_offramp_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/hasher.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/price_registry.go:21:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/price_registry_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/price_registry_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_1_0/onramp.go:13:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_1_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_1_0
core/services/ocr2/plugins/ccip/internal/pricegetter/evm.go:16:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/aggregator_v3_interface; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/aggregator_v3_interface

Why: The Go build process is failing because several required modules are not provided. These modules are necessary for the build process to complete successfully.

Suggested fix: Run go get commands for each missing module to add them to the project. Ensure that the go.mod file is updated accordingly.

3. Missing required Go modules:go_core_ccip_deployment_tests

Source of Error:

core/services/ocr2/plugins/ccip/config/type_and_version.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/type_and_version_interface_wrapper; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/type_and_version_interface_wrapper
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/commit_store.go:25:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/commit_store_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/commit_store_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/offramp.go:30:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_offramp_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_offramp_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/hasher.go:12:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_0_0/price_registry.go:21:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/price_registry_1_0_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/price_registry_1_0_0
core/services/ocr2/plugins/ccip/internal/ccipdata/v1_1_0/onramp.go:13:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_1_0; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/evm_2_evm_onramp_1_1_0
core/services/ocr2/plugins/ccip/internal/pricegetter/evm.go:16:2: no required module provides package github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/aggregator_v3_interface; to add it:
	go get github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/aggregator_v3_interface

Why: The Go build process is failing because several required modules are not provided. These modules are necessary for the build process to complete successfully.

Suggested fix: Run go get commands for each missing module to add them to the project. Ensure that the go.mod file is updated accordingly.

4. Undefined fields or methods:golangci-lint

Source of Error:

core/internal/cltest/cltest.go:263:38: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	k, _ := MustInsertRandomKey(t, app.KeyStore.Eth(), chainID)
core/internal/cltest/cltest.go:266:34: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	id, ks := chainID.ToInt(), app.KeyStore.Eth()
core/internal/cltest/cltest.go:279:25: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	require.NoError(t, app.KeyStore.Unlock(ctx, Password))
core/internal/cltest/cltest.go:286:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
	require.NoError(t, app.GetKeyStore().P2P().Add(ctx, v))
core/internal/cltest/cltest.go:288:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
	require.NoError(t, app.GetKeyStore().CSA().Add(ctx, v))
core/internal/cltest/cltest.go:290:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
	require.NoError(t, app.GetKeyStore().OCR2().Add(ctx, v))
core/internal/cltest/cltest.go:641:12: ta.GetDB undefined (type *TestApplication has no field or method GetDB) (typecheck)
	err := ta.GetDB().GetContext(ctx, &id, `INSERT INTO sessions (id, email, last_used, created_at) VALUES ($1, $2, $3, NOW()) RETURNING id`, session.ID, email, session.LastUsed)
core/internal/cltest/cltest.go:648:27: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	require.NoError(ta.t, ta.KeyStore.Unlock(ctx, Password))
core/internal/cltest/cltest.go:649:15: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
	_, err := ta.KeyStore.Eth().Import(ctx, []byte(content), Password, &FixtureChainID)
core/internal/cltest/cltest.go:677:11: ta.BasicAdminUsersORM undefined (type *TestApplication has no field or method BasicAdminUsersORM) (typecheck)
	err = ta.BasicAdminUsersORM().CreateUser(ctx, &u)
core/internal/cltest/cltest.go:699:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
	Config: ta.GetConfig(),
core/internal/cltest/cltest.go:718:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
	Config: ta.GetConfig(),
core/internal/cltest/cltest.go:1310:95: app.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
	ethClient.On("ConfiguredChainID", mock.Anything).Return(evmtest.MustGetDefaultChainID(t, app.GetConfig().EVMConfigs()), nil)
core/capabilities/integration_tests/framework/don.go:260:18: node.Stop undefined (type *capabilityNode has no field or method Stop) (typecheck)
	if err := node.Stop(); err != nil {
core/capabilities/integration_tests/framework/don.go:337:15: node.AddJobV2 undefined (type *capabilityNode has no field or method AddJobV2) (typecheck)
	err := node.AddJobV2(ctx, j)
core/services/ocr2/plugins/ccip/testhelpers/ccip_contracts.go:183:41: undefined: rmn_proxy_contract.RMNProxyContract (typecheck)
	ARMProxy *rmn_proxy_contract.RMNProxyContract
core/services/ocr2/plugins/ccip/testhelpers/ccip_contracts.go:523:2: not enough arguments in call to confighelper.ContractSetConfigArgsForTests
	have ("time".Duration, "time".Duration, "time".Duration, "time".Duration, "time".Duration, number, []int, []"github.com/smartcontractkit/libocr/offchainreporting2plus/confighelper".OracleIdentityExtra, []byte, "time".Duration, "time".Duration, "time".Duration, "time".Duration, "time".Duration, number, []byte)
	want ("time".Duration, "time".Duration, "time".Duration, "time".Duration, "time".Duration, uint8, []int, []"github.com/smartcontractkit/libocr/offchainreporting2plus/confighelper".OracleIdentityExtra, []byte, *"time".Duration, "time".Duration, "time".Duration, "time".Duration, "time".Duration, "time".Duration, int, []byte) (typecheck)
core/services/ocr2/plugins/ccip/testhelpers/ccip_contracts.go:676:57: undefined: rmn_proxy_contract.DeployRMNProxyContract (typecheck)
	armProxySourceAddress, _, _, err := rmn_proxy_contract.DeployRMNProxyContract(
core/services/ocr2/plugins/ccip/testhelpers/ccip_contracts.go:682:44: undefined: rmn_proxy_contract.NewRMNProxyContract (typecheck)
	sourceARMProxy, err := rmn_proxy_contract.NewRMNProxyContract(armProxySourceAddress, sourceChain)
core/services/ocr2/plugins/ccip/testhelpers/ccip_contracts.go:691:55: undefined: rmn_proxy_contract.DeployRMNProxyContract (typecheck)
	armProxyDestAddress, _, _, err := rmn_proxy_contract.DeployRMNProxyContract(
core/services/ocr2/plugins/ccip/testhelpers/ccip_contracts.go:700:42: undefined: rmn_proxy_contract.NewRMNProxyContract (typecheck)
	destARMProxy, err := rmn_proxy_contract.NewRMNProxyContract(armProxyDestAddress, destChain)
core/services/ocr2/plugins/ccip/testhelpers/ccip_contracts.go:1589:36: c.Dest.Chain.Blockchain undefined (type *backends.SimulatedBackend has no field or method Blockchain) (typecheck)
	DestLatestBlockNum: c.Dest.Chain.Blockchain().CurrentBlock().Number.Uint64(),
core/services/ocr2/plugins/ccip/testhelpers/simulated_backend.go:37:42: chain.Blockchain undefined (type *backends.SimulatedBackend has no field or method Blockchain) (typecheck)
	blockTime := time.UnixMilli(int64(chain.Blockchain().CurrentHeader().Time))
core/services/ocr2/plugins/ccip/testhelpers/integration/chainlink.go:180:90: ccipContracts.Dest undefined (type CCIPIntegrationTestHarness has no field or method Dest) (typecheck)
	c, err := node.App.GetRelayers().LegacyEVMChains().Get(strconv.FormatUint(ccipContracts.Dest.ChainID, 10))
core/services/ocr2/plugins/ccip/testhelpers/integration/chainlink.go:197:131: ccipContracts.Dest undefined (type CCIPIntegrationTestHarness has no field or method Dest) (typecheck)
	}, testutils.WaitTimeout(t), 1*time.Second).Should(gomega.BeTrue(), "node is not using updated price registry %s", ccipContracts.Dest.PriceRegistry.Address().Hex())
core/services/ocr2/plugins/ccip/testhelpers/integration/chainlink.go:184:17: ccipContracts.Source undefined (type CCIPIntegrationTestHarness has no field or method Source) (typecheck)
	ccipContracts.Source
</cicore>