Add Solana chain reader config to plugin creator #15876
Open
+46
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huangzhen1997
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang,
b-gopalswami and
krehermann
and removed request for
a team
| lggr.Debugw("Adding home chain reader config", "chainID", chainID) | ||
| chainReaderConfig = evmconfig.MergeReaderConfigs(chainReaderConfig, evmconfig.HomeChainReaderConfigRaw) | ||
| } | ||
| if chainID == homeChainID { |
There was a problem hiding this comment.
This home chain config merging with local raw config will likely be needed for Solana too.
Because tooling team will add some configs to home chain, and some to local node.
So its good to add this config merging logic to solana too.
Or better, make it generic for all chain families if possible. I mean after fetching all local configs separately for each chain family, at the end, do a merge with home chain config, that is chain family agnostic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket https://smartcontract-it.atlassian.net/browse/NONEVM-933
This PR remove EVM specific dependency, and add Solana support for chain reader config in plugin logic. At the moment, the Solana program address required for the plugin are not yet available. They will be configured later in a different PR, and an empty place holder will be used now for unblocking E2E test.