Cleanup on primary key position #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
commented
Feb 2, 2024
| @@ -4,6 +4,8 @@ | |||
| {%- endif -%} | |||
| {%- endmacro -%} | |||
|
|
|||
| {#- TODO: move secondary/tertiary resource declaration upstream to | |||
There was a problem hiding this comment.
these are my attempt to address the dangling comment from the prior PR i pulled the trigger on early
There was a problem hiding this comment.
You didn’t pull early really, I was just being verbose in the comments 😄
| with helper.query_console_output( | ||
| verbose, drop_view_table, progress, task | ||
| ) as v: | ||
| with helper.query_console_output(verbose, drop_view_table, progress, task): |
There was a problem hiding this comment.
dangling debug from the last PR
mikix
approved these changes
Feb 2, 2024
| @@ -4,6 +4,8 @@ | |||
| {%- endif -%} | |||
| {%- endmacro -%} | |||
|
|
|||
| {#- TODO: move secondary/tertiary resource declaration upstream to | |||
There was a problem hiding this comment.
You didn’t pull early really, I was just being verbose in the comments 😄
| @@ -35,18 +35,6 @@ | |||
| } | |||
|
|
|||
|
|
|||
| class ResourceTableIdPos(IntEnum): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
idChecklist
docs/) needs to be updated