Switch --smart-jwks to --smart-key and accept PEM keys #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
commented
Jan 10, 2025
dogversioning
approved these changes
Jan 10, 2025
| # Yes, P-521 is not a typo, it's what the curve is called. | ||
| # The curve uses 521 bits, but it's hashed with SHA512, so it's called ES512. |
There was a problem hiding this comment.
case study in 'im glad i don't work in cryptography' right there
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mikix
changed the title
mikix
force-pushed
the
mikix/pem
branch
2 times, most recently
from
f2e74c6 to
de656d6
Compare
Some servers (notably Epic) support using a private key as an alternative to a JWK Set. So let's add support for that too. It's a little fussier, but easy enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers (notably Epic) support using a private key as an alternative to a JWK Set. So let's add support for that too.
It's a little fussier, but easy enough.
Checklist
docs/) needs to be updated