Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add git revision to version during docker build #348

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Sep 24, 2024

Using a "local version identifier" per PEP 440, the version looks like: 1.3.0+d7abeb366a8179691f3234502986dad14698a4c5

PEP for reference: https://peps.python.org/pep-0440/

This will help distinguish ETL builds from each other while we still build directly from git.

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

@mikix mikix marked this pull request as draft September 24, 2024 19:13
@mikix mikix force-pushed the mikix/docker-version branch from 665fd9b to acaf31c Compare September 24, 2024 19:13
Copy link

github-actions bot commented Sep 24, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3448 3386 98% 98% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 28cfb7b by action🐍

@mikix mikix force-pushed the mikix/docker-version branch 4 times, most recently from 9cccd75 to c7e9a74 Compare September 25, 2024 15:18
Using a "local version identifier" per PEP 440,
the version looks like: 1.3.0+d7abeb3

PEP for reference: https://peps.python.org/pep-0440/

This will help distinguish ETL builds from each other while we still
build directly from git.
@mikix mikix force-pushed the mikix/docker-version branch from c7e9a74 to 28cfb7b Compare September 25, 2024 15:27
@mikix mikix marked this pull request as ready for review September 25, 2024 15:32
@mikix mikix merged commit 047b279 into main Sep 25, 2024
3 checks passed
@mikix mikix deleted the mikix/docker-version branch September 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants