Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

medicationrequest: don't spam console with "need --fhir-url" errors #342

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Aug 28, 2024

If an error occurs while downloading Medication references, it's likely going to repeat itself (missing --fhir-url, server being down, etc).

So just print it once.

Fixes: #341

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

If an error occurs while downloading Medication references, it's likely
going to repeat itself (missing --fhir-url, server being down, etc).

So just print it once.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixing the github warnings in PRs on this file.

Copy link

github-actions bot commented Aug 28, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3374 3296 98% 97% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cumulus_etl/etl/tasks/basic_tasks.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 4605c81 by action🐍

@mikix mikix force-pushed the mikix/no-med-spam branch from 4dd22ce to 4605c81 Compare August 28, 2024 17:23
@mikix mikix merged commit 55db90e into main Aug 28, 2024
3 checks passed
@mikix mikix deleted the mikix/no-med-spam branch August 28, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show the error "can't download medication, need --fhir-url" once
2 participants