Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple small fixes #286

Merged
merged 2 commits into from
Oct 30, 2023
Merged

A couple small fixes #286

merged 2 commits into from
Oct 30, 2023

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Oct 30, 2023 •
edited
Loading

Two commits:

  • One is a doc broken link fix
  • The other adjusts the "ndjson format overwrite detection" code to allow for .meta files which NLP jobs also write out in addition to .ndjson

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

mikix added 2 commits October 30, 2023 09:00
@mikix
docs: fix link to source that changed after a refactor
a9cdbd4
@mikix
fix: change overwrite detection to also allow .meta files
53d243e 
Our ndjson format's new overwrite warning only looked for .ndjson
files but we can also write .meta files for NLP jobs. So allow
that sort of file too.
@mikix mikix merged commit 43436f1 into main Oct 30, 2023
2 checks passed
@mikix mikix deleted the mikix/tweaks branch October 30, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogversioning dogversioning dogversioning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikix @dogversioning