-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: add a coverage check at end of unit tests
It's currently set to require all new & modified code to be fully covered. And to allow the current coverage score of 94% in general.
- Loading branch information
Showing
3 changed files
with
22 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,21 +19,21 @@ jobs: | |
runs-on: ubuntu-22.04 | ||
strategy: | ||
matrix: | ||
# while we are still private, don't go crazy with the Python versions as they eat up CI minutes | ||
# Don't go crazy with the Python versions as the test suite is a beast. | ||
# Just test the minimum version we support. | ||
python-version: ["3.10"] | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v4 | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install pytest | ||
pip install .[tests] | ||
- name: Check out MS tool | ||
|
@@ -55,7 +55,17 @@ jobs: | |
- name: Test with pytest | ||
run: | | ||
python -m pytest | ||
python -m pytest --cov-report=xml --cov=cumulus_etl | ||
- name: Generate coverage report | ||
if: github.ref != 'refs/heads/main' | ||
uses: orgoro/[email protected] | ||
with: | ||
coverageFile: coverage.xml | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
thresholdAll: .94 | ||
thresholdNew: 1 | ||
thresholdModified: 1 | ||
|
||
nlp-regression: | ||
runs-on: ubuntu-latest | ||
|
@@ -99,15 +109,14 @@ jobs: | |
echo "All Good!" | ||
lint: | ||
runs-on: ubuntu-22.04 | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Install linters | ||
# black is synced with the .pre-commit-hooks version | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install bandit[toml] pycodestyle pylint 'black >= 24, < 25' | ||
pip install .[dev] | ||
- name: Run pycodestyle | ||
# E203: pycodestyle is a little too rigid about slices & whitespace | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters