fix: address some STA warnings

Directory.Build.props

@@ -6,7 +6,7 @@
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <WarnOnPackingNonPackableProject>false</WarnOnPackingNonPackableProject>
-    <NoWarn>$(NoWarn);IDE0079;S1135;CA1510;CA1511;CA1512;CA1513;CA1863</NoWarn>
+    <NoWarn>$(NoWarn);IDE0079;S1135;CA1510;CA1511;CA1512;CA1513;CA1863;S1939;S1133</NoWarn>
     <NoWarn Condition="'$(Configuration)'=='Release'">$(NoWarn);NETSDK1138</NoWarn>
     <WarningsAsErrors>$(WarningsAsErrors);NU1601;NU1603;NU1605;NU1608;NU1701;MSB3644</WarningsAsErrors>
     <ContinuousIntegrationBuild Condition="'$(CI)'!=''">true</ContinuousIntegrationBuild>

src/MockHttp/Extensions/IRespondsExtensions.cs

@@ -65,22 +65,6 @@ public static TResult Respond<TResult>(this IResponds<TResult> responds, Action<
         return responds.RespondUsing(new RequestSpecificResponseBuilder(with));
     }
 
-    /// <summary>
-    /// Specifies a strategy that returns the response for a request.
-    /// </summary>
-    /// <param name="responds"></param>
-    internal static TResult RespondUsing<TStrategy, TResult>(this IResponds<TResult> responds)
-        where TStrategy : IResponseStrategy, new()
-        where TResult : IResponseResult
-    {
-        if (responds is null)
-        {
-            throw new ArgumentNullException(nameof(responds));
-        }
-
-        return responds.RespondUsing(new TStrategy());
-    }
-
     /// <summary>
     /// Configures a response via the response builder API.
     /// </summary>
@@ -121,6 +105,22 @@ public static TResult Respond<TResult>(this IResponds<TResult> responds, Action<
         return responds.Respond((ctx, _, builder) => with(ctx, builder));
     }
 
+    /// <summary>
+    /// Specifies a strategy that returns the response for a request.
+    /// </summary>
+    /// <param name="responds"></param>
+    internal static TResult RespondUsing<TStrategy, TResult>(this IResponds<TResult> responds)
+        where TStrategy : IResponseStrategy, new()
+        where TResult : IResponseResult
+    {
+        if (responds is null)
+        {
+            throw new ArgumentNullException(nameof(responds));
+        }
+
+        return responds.RespondUsing(new TStrategy());
+    }
+
     private sealed class RequestSpecificResponseBuilder : IResponseStrategy
     {
         private readonly Action<MockHttpRequestContext, CancellationToken, IResponseBuilder> _with;

src/MockHttp/HttpMockException.cs

@@ -36,7 +36,9 @@ internal HttpMockException(string message, Exception innerException) : base(mess
     /// <inheritdoc />
     [ExcludeFromCodeCoverage]
 #if NET8_0_OR_GREATER
+#pragma warning disable CA1041
     [Obsolete(DiagnosticId = "SYSLIB0051")]
+#pragma warning restore CA1041
 #endif
     protected HttpMockException(SerializationInfo info, StreamingContext context)
         : base(info, context)

src/MockHttp/IsSent.cs

@@ -8,16 +8,12 @@ namespace MockHttp;
 public sealed class IsSent
 {
     private readonly Func<int, bool> _evaluator;
-    private readonly int _min;
-    private readonly int _max;
     private readonly string _name;
     private readonly string _message;
 
-    private IsSent(Func<int, bool> evaluator, int min, int max, string name, string message)
+    private IsSent(Func<int, bool> evaluator, string name, string message)
     {
         _evaluator = evaluator ?? throw new ArgumentNullException(nameof(evaluator));
-        _min = min;
-        _max = max;
         _name = name;
         _message = message;
     }
@@ -32,15 +28,23 @@ public static IsSent AtLeast(int callCount)
             throw new ArgumentOutOfRangeException(nameof(callCount));
         }
 
-        return new IsSent(i => i >= callCount, callCount, int.MaxValue, $"{nameof(AtLeast)}({callCount})", $"Expected request to have been sent at least {callCount} time(s){{0}}, but was sent only {{1}} time(s).");
+        return new IsSent(
+            i => i >= callCount,
+            $"{nameof(AtLeast)}({callCount})",
+            $"Expected request to have been sent at least {callCount} time(s){{0}}, but was sent only {{1}} time(s)."
+        );
     }
 
     /// <summary>
     /// Specifies that the mocked request should be sent one time at minimum.
     /// </summary>
     public static IsSent AtLeastOnce()
     {
-        return new IsSent(i => i >= 1, 1, int.MaxValue, nameof(AtLeastOnce), "Expected request to have been sent at least once{0}, but it was not.");
+        return new IsSent(
+            i => i >= 1,
+            nameof(AtLeastOnce),
+            "Expected request to have been sent at least once{0}, but it was not."
+        );
     }
 
     /// <summary>
@@ -53,15 +57,23 @@ public static IsSent AtMost(int callCount)
             throw new ArgumentOutOfRangeException(nameof(callCount));
         }
 
-        return new IsSent(i => i <= callCount, 0, callCount, $"{nameof(AtMost)}({callCount})", $"Expected request to have been sent at most {callCount} time(s){{0}}, but was actually sent {{1}} time(s).");
+        return new IsSent(
+            i => i <= callCount,
+            $"{nameof(AtMost)}({callCount})",
+            $"Expected request to have been sent at most {callCount} time(s){{0}}, but was actually sent {{1}} time(s)."
+        );
     }
 
     /// <summary>
     /// Specifies that the mocked request should be sent one time at maximum.
     /// </summary>
     public static IsSent AtMostOnce()
     {
-        return new IsSent(i => i <= 1, 0, 1, nameof(AtMostOnce), "Expected request to have been sent at most once{0}, but was actually sent {1} time(s).");
+        return new IsSent(
+            i => i <= 1,
+            nameof(AtMostOnce),
+            "Expected request to have been sent at most once{0}, but was actually sent {1} time(s)."
+        );
     }
 
     /// <summary>
@@ -74,23 +86,35 @@ public static IsSent Exactly(int callCount)
             throw new ArgumentOutOfRangeException(nameof(callCount));
         }
 
-        return new IsSent(i => i == callCount, callCount, callCount, $"{nameof(Exactly)}({callCount})", $"Expected request to have been sent exactly {callCount} time(s){{0}}, but was actually sent {{1}} time(s).");
+        return new IsSent(
+            i => i == callCount,
+            $"{nameof(Exactly)}({callCount})",
+            $"Expected request to have been sent exactly {callCount} time(s){{0}}, but was actually sent {{1}} time(s)."
+        );
     }
 
     /// <summary>
     /// Specifies that the mocked request should not be sent.
     /// </summary>
     public static IsSent Never()
     {
-        return new IsSent(i => i == 0, 0, 0, nameof(Never), "Expected request to have never been sent{0}, but was actually sent {1} time(s).");
+        return new IsSent(
+            i => i == 0,
+            nameof(Never),
+            "Expected request to have never been sent{0}, but was actually sent {1} time(s)."
+        );
     }
 
     /// <summary>
     /// Specifies that the mocked request should be sent exactly one time.
     /// </summary>
     public static IsSent Once()
     {
-        return new IsSent(i => i == 1, 1, 1, nameof(Once), "Expected request to have been sent exactly once{0}, but was actually sent {1} time(s).");
+        return new IsSent(
+            i => i == 1,
+            nameof(Once),
+            "Expected request to have been sent exactly once{0}, but was actually sent {1} time(s)."
+        );
     }
 
     internal bool Verify(int callCount)
@@ -100,7 +124,12 @@ internal bool Verify(int callCount)
 
     internal string GetErrorMessage(int actualCount, string becauseMessage)
     {
-        return string.Format(CultureInfo.CurrentCulture, _message, becauseMessage, actualCount);
+        return string.Format(
+            CultureInfo.CurrentCulture,
+            _message,
+            becauseMessage,
+            actualCount
+        );
     }
 
     /// <inheritdoc />

test/Directory.Build.targets

@@ -5,6 +5,7 @@
     <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
     <NoWarn>$(NoWarn);NU1902;NU1903</NoWarn>
     <NetTestSdkVersion>17.11.1</NetTestSdkVersion>
+    <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(TargetFramework)'=='netcoreapp2.1'">