-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include classes that lack schedules + split off IAP/summer #100
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
df7b2e5
Update field names in fireroad.py comments
psvenk 8ab43b4
Include classes that don't have schedules
psvenk 52c10a7
Filter to classes that are offered this term
psvenk 0d1a792
Add warning for no schedule
psvenk 7e8b40d
Add "preSemester" to latestTerm.json
psvenk 6c62955
Store only the latest term's urlName in State
psvenk 4925261
Add pre-semester support to scrapers
psvenk 4bcd513
add new artifacts to gitignore
dtemkin1 2e87950
Read from scheduleFall, scheduleIAP, scheduleSpring
psvenk 69b6471
Output pre-semester to properly named file
psvenk d0c17d5
Add support for summer term
psvenk 550a4dd
wrong excluded url
dtemkin1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,27 @@ | ||
{ | ||
"urlName": "s25", | ||
"startDate": "2025-02-03", | ||
"h1EndDate": "2025-03-21", | ||
"h2StartDate": "2025-03-31", | ||
"endDate": "2025-05-13", | ||
"mondayScheduleDate": "2025-02-18", | ||
"holidayDates": [ | ||
"2025-02-17", | ||
"2025-03-24", | ||
"2025-03-25", | ||
"2025-03-26", | ||
"2025-03-27", | ||
"2025-03-28", | ||
"2025-04-21" | ||
] | ||
"preSemester": { | ||
"urlName": "i25", | ||
"startDate": "2025-01-06", | ||
"endDate": "2025-01-31", | ||
"holidayDates": [ | ||
"2025-01-20" | ||
] | ||
}, | ||
"semester": { | ||
"urlName": "s25", | ||
"startDate": "2025-02-03", | ||
"h1EndDate": "2025-03-21", | ||
"h2StartDate": "2025-03-31", | ||
"endDate": "2025-05-13", | ||
"mondayScheduleDate": "2025-02-18", | ||
"holidayDates": [ | ||
"2025-02-17", | ||
"2025-03-24", | ||
"2025-03-25", | ||
"2025-03-26", | ||
"2025-03-27", | ||
"2025-03-28", | ||
"2025-04-21" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no other way of making sure we don't commit presemester? I feel like this will start getting bloated after a few semesters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main other way that I can think of is to put the latest pre-semester in
public/latestPreSemester.json
and then to add a special case tosrc/lib/TermSwitcher.tsx
so that theurlName
corresponding to the latest pre-semester will read from the filepublic/latestPreSemester.json
.This would break the correspondence between
urlName
s and JSON file names that we have now; e.g.,https://hydrant.mit.edu/?t=latest
loads Spring 2025 whilehttps://hydrant.mit.edu/?t=s25
does not, since the file islatest.json
and not yets25.json
.Alternatively, we could make
public/i25.json
a symlink topublic/latestPreSemester.json
, but then the maintenance task on each semester is changed from editing.gitignore
to modifying a symlink (which is IMO marginally worse).Bloat shouldn't become an issue here, since it's only the latest pre-semester that needs to be ignored; when the fall 2025 listings are out,
public/i25.json
should be committed (along withpublic/s25.json
) and it will bepublic/m25.json
that will need to be ignored.