Support for relative urls in external maps. Resolves #17 (#18)

* Support for relative urls in external maps. Resolves #17 * Use pretty-quick
single-spa · Oct 16, 2024 · 86f5d1c · 86f5d1c
1 parent b97db77
commit 86f5d1c
Show file tree

Hide file tree

Showing 9 changed files with 360 additions and 19 deletions.
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1,4 +1,4 @@
 #!/usr/bin/env sh
 . "$(dirname -- "$0")/_/husky.sh"
 
-pnpm run format && pnpm run lint
+pnpm exec pretty-quick --staged && pnpm run lint
diff --git a/fixtures/parent/dot.js b/fixtures/parent/dot.js
@@ -0,0 +1 @@
+console.log("parent/dot");
diff --git a/fixtures/parent/dot2.js b/fixtures/parent/dot2.js
@@ -0,0 +1,3 @@
+import "dot";
+
+console.log("parent/dot2");
diff --git a/fixtures/relative.html b/fixtures/relative.html
@@ -0,0 +1,19 @@
+<!doctype html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>Document</title>
+    <script type="injector-importmap" src="./relative.importmap"></script>
+  </head>
+  <body>
+    <script src="../lib/import-map-injector.js"></script>
+    <script>
+      window.importMapInjector.initPromise.then(() => {
+        import("dot");
+        import("dotdot");
+        import("slash");
+      });
+    </script>
+  </body>
+</html>
diff --git a/fixtures/relative.importmap b/fixtures/relative.importmap
@@ -0,0 +1,12 @@
+{
+  "imports": {
+    "dot": "./basic.js",
+    "dotdot": "../fixtures/basic2.js",
+    "slash": "/fixtures/parent/dot2.js"
+  },
+  "scopes": {
+    "./parent/": {
+      "dot": "./parent/dot.js"
+    }
+  }
+}
diff --git a/fixtures/server.js b/fixtures/server.js
diff --git a/package.json b/package.json
@@ -24,7 +24,7 @@
     "check-format": "prettier --check .",
     "watch": "rollup -cw",
     "test": "echo \"No tests\"",
-    "test-serve": "node fixtures/server.js",
+    "test-serve": "http-server --mimetypes '{ \"application/importmap+json\": [\"importmap\"] }'",
     "build": "concurrently pnpm:build:*",
     "prepublishOnly": "pnpm run build",
     "build:types": "tsc",
@@ -44,8 +44,10 @@
     "eslint": "^8.47.0",
     "eslint-config-ts-important-stuff": "^1.1.0",
     "express": "^4.18.2",
+    "http-server": "^14.1.1",
     "husky": "^8.0.3",
     "prettier": "^3.0.2",
+    "pretty-quick": "^4.0.0",
     "rollup": "^3.28.0",
     "typescript": "^5.1.6"
   },