Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump facebook_business SDK to v21.0.5 #242

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

sgandhi1311
Copy link
Member

@sgandhi1311 sgandhi1311 commented Dec 27, 2024

Description of change

API Version Update

  • Upgrading Facebook Marketing API SDK from v19 to v21.0.5
  • Reason: Facebook Marketing API v19 will reach end-of-life on February 4, 2025
  • This is a proactive upgrade to ensure continued API compatibility

Testing Changes

  1. Current Situation
  • All campaigns in the Facebook test account are currently paused
  • Due to paused campaigns, no insight data is being generated
  • Impact: Unable to test insight-related data streams

Test Modifications

  1. Integration Tests:
  • Temporarily excluded all insights stream testing
  • This includes metrics like impressions, clicks, and conversion data
  1. Attribution Window Testing:
  • Attribution window tests have been commented out
  • These tests were specifically designed for insights streams
  • Will need to be re-enabled once test data is available

Manuak QA Steps:

  1. Check API version compatibility:
  • Confirm all existing endpoints work with v21.0.5
  • Verify response formats haven't changed

Risks

API Version Related:

  • Potential breaking changes in v21.0.5
  • New endpoint formats or deprecated features
  • Response schema modifications

Testing Coverage:

  • Reduced test coverage due to disabled insight tests
  • Potential issues might go undetected in insights-related functionality

Mitigation Steps

Plan to re-enable insight tests:

  • Create new active test campaigns
  • Update test data sets
  • Re-implement attribution window tests

Rollback Steps

  • Revert this branch to previous version
  • This will restore v19 API implementation

@sgandhi1311 sgandhi1311 changed the title update facebook sdk Bump facebook_business SDK to v21.0.5 Dec 27, 2024
@bhtowles bhtowles requested a review from luandy64 January 8, 2025 20:16
Copy link
Contributor

@bhtowles bhtowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants