fix: properly generate labels meta in the UI #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the UI use proper data format for the machine labels meta value when generating the image on the `DownloadInstallationMedia` page. Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
force-pushed
the
fix-labels-generation-ui
branch
from
6f492be to
47d8429
Compare
TimJones
approved these changes
Mar 4, 2024
|
Can we update the schematic at least in the integration test to include the labels and assert on them in the test? |
smira
approved these changes
Mar 4, 2024
Yeah, can do that. |
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the UI use proper data format for the machine labels meta value when generating the image on the
DownloadInstallationMediapage.