fix: cleanup tearing down machine links without finalizers #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
Mar 1, 2024
Unix4ever
force-pushed
the
cleanup-links
branch
3 times, most recently
from
857d5cf to
2ac3bca
Compare
Unix4ever
added
integration/e2e
This should help with the cleanup of machines removed from Omni completely. If the link is torn down, it will automatically trigger the removal of `MachineSetNode` if it exists. When the link has no linked resources it will be automatically removed from the state. Signed-off-by: Artem Chernyshev <[email protected]>
DmitriyMV
approved these changes
Mar 1, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with the cleanup of machines removed from Omni completely.
If the link is torn down, it will automatically trigger the removal of
MachineSetNodeif it exists.When the link has no linked resources it will be automatically removed from the state.