refactor: convert MachineSetStatus controller to QController
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix4ever
force-pushed
the
refactor-machine-set-status-controller
branch
2 times, most recently
from
cdaea62 to
3d98ea3
Compare
Unix4ever
force-pushed
the
refactor-machine-set-status-controller
branch
2 times, most recently
from
d5f6f6d to
882d7ff
Compare
Unix4ever
commented
Mar 1, 2024
internal/backend/runtime/omni/controllers/omni/cluster_machine_config_status.go
Show resolved
Hide resolved
Unix4ever
commented
Mar 1, 2024
internal/backend/runtime/omni/controllers/omni/cluster_machine_config_status.go
Outdated
Show resolved
Hide resolved
frezbo
reviewed
Mar 4, 2024
internal/backend/runtime/omni/controllers/omni/cluster_machine_config_status.go
Outdated
Show resolved
Hide resolved
frezbo
reviewed
Mar 4, 2024
internal/backend/runtime/omni/controllers/omni/cluster_machine_status.go
Show resolved
Hide resolved
frezbo
reviewed
Mar 4, 2024
internal/backend/runtime/omni/controllers/omni/internal/machineset/control_planes_handler.go
Outdated
Show resolved
Hide resolved
Unix4ever
force-pushed
the
refactor-machine-set-status-controller
branch
2 times, most recently
from
a6e19c4 to
87666eb
Compare
smira
approved these changes
Mar 5, 2024
internal/backend/runtime/omni/controllers/omni/cluster_machine_config_status.go
Outdated
Show resolved
Hide resolved
internal/backend/runtime/omni/controllers/omni/cluster_machine_teardown.go
Outdated
Show resolved
Hide resolved
internal/backend/runtime/omni/controllers/omni/internal/machineset/machineset.go
Show resolved
Hide resolved
Pretty much replace the controller code, restructure, split it to smaller chunks and cover with tests. Extract machine teardown logic to a separate controller. Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
force-pushed
the
refactor-machine-set-status-controller
branch
from
87666eb to
0eed757
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much replace the controller code, restructure, split it to smaller chunks and cover with tests.
Extract machine teardown logic to a separate controller.
Fixes: #8