feat: Add maxScale property
#40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shuding
reviewed
Mar 1, 2023
There was a problem hiding this comment.
Hey - appreciate your PR as well as updating the website! These changes look good to me but I'm not sure about adding this to the lib. I can't think of a common use case, and it's not really related to wrap balancing — maybe you can create a fork and share some use cases to see if there're more people interested adding it upstream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
maxScaleproperty to the<Balancer>component that allows it to scale text to be larger (up tomaxScale * fontSize) so that the edges of the widest line will be flush to the edges of the container. If this property is not explicitly set, it defaults to1and behaves the same as before.