interfaces cleanup (#3732)

shopsys · Jan 17, 2025 · 7039722 · 7039722
2 parents 1040205 + 8a09efd
commit 7039722
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 45 deletions.
diff --git a/src/DataFixtures/HeurekaCategoryDataFixture.php b/src/DataFixtures/HeurekaCategoryDataFixture.php
@@ -5,7 +5,7 @@
 namespace Shopsys\ProductFeed\HeurekaBundle\DataFixtures;
 
 use Shopsys\Plugin\PluginDataFixtureInterface;
-use Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryDataFactoryInterface;
+use Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryDataFactory;
 use Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryFacade;
 
 class HeurekaCategoryDataFixture implements PluginDataFixtureInterface
@@ -22,11 +22,11 @@ class HeurekaCategoryDataFixture implements PluginDataFixtureInterface
 
     /**
      * @param \Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryFacade $heurekaCategoryFacade
-     * @param \Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryDataFactoryInterface $heurekaCategoryDataFactory
+     * @param \Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryDataFactory $heurekaCategoryDataFactory
      */
     public function __construct(
         private readonly HeurekaCategoryFacade $heurekaCategoryFacade,
-        private readonly HeurekaCategoryDataFactoryInterface $heurekaCategoryDataFactory,
+        private readonly HeurekaCategoryDataFactory $heurekaCategoryDataFactory,
     ) {
     }
 

diff --git a/src/DataFixtures/HeurekaProductDataFixture.php b/src/DataFixtures/HeurekaProductDataFixture.php
@@ -6,7 +6,7 @@
 
 use Shopsys\FrameworkBundle\Component\Money\Money;
 use Shopsys\Plugin\PluginDataFixtureInterface;
-use Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactoryInterface;
+use Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactory;
 use Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainFacade;
 
 class HeurekaProductDataFixture implements PluginDataFixtureInterface
@@ -21,11 +21,11 @@ class HeurekaProductDataFixture implements PluginDataFixtureInterface
 
     /**
      * @param \Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainFacade $heurekaProductDomainFacade
-     * @param \Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactoryInterface $heurekaProductDomainDataFactory
+     * @param \Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactory $heurekaProductDomainDataFactory
      */
     public function __construct(
         private readonly HeurekaProductDomainFacade $heurekaProductDomainFacade,
-        private readonly HeurekaProductDomainDataFactoryInterface $heurekaProductDomainDataFactory,
+        private readonly HeurekaProductDomainDataFactory $heurekaProductDomainDataFactory,
     ) {
     }
 

diff --git a/src/Form/HeurekaProductCrudExtension.php b/src/Form/HeurekaProductCrudExtension.php
@@ -5,7 +5,7 @@
 namespace Shopsys\ProductFeed\HeurekaBundle\Form;
 
 use Shopsys\Plugin\PluginCrudExtensionInterface;
-use Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactoryInterface;
+use Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactory;
 use Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainFacade;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
@@ -14,12 +14,12 @@ class HeurekaProductCrudExtension implements PluginCrudExtensionInterface
     /**
      * @param \Symfony\Contracts\Translation\TranslatorInterface $translator
      * @param \Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainFacade $heurekaProductDomainFacade
-     * @param \Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactoryInterface $heurekaProductDomainDataFactory
+     * @param \Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactory $heurekaProductDomainDataFactory
      */
     public function __construct(
         private readonly TranslatorInterface $translator,
         private readonly HeurekaProductDomainFacade $heurekaProductDomainFacade,
-        private readonly HeurekaProductDomainDataFactoryInterface $heurekaProductDomainDataFactory,
+        private readonly HeurekaProductDomainDataFactory $heurekaProductDomainDataFactory,
     ) {
     }
 

diff --git a/src/Model/HeurekaCategory/HeurekaCategoryDataFactory.php b/src/Model/HeurekaCategory/HeurekaCategoryDataFactory.php
@@ -4,7 +4,7 @@
 
 namespace Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory;
 
-class HeurekaCategoryDataFactory implements HeurekaCategoryDataFactoryInterface
+class HeurekaCategoryDataFactory
 {
     /**
      * @return \Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryData

diff --git a/src/Model/HeurekaCategory/HeurekaCategoryDataFactoryInterface.php b/src/Model/HeurekaCategory/HeurekaCategoryDataFactoryInterface.php
diff --git a/src/Model/HeurekaCategory/HeurekaCategoryDownloader.php b/src/Model/HeurekaCategory/HeurekaCategoryDownloader.php
@@ -13,11 +13,11 @@ class HeurekaCategoryDownloader
 
     /**
      * @param string $heurekaCategoryFeedUrl
-     * @param \Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryDataFactoryInterface $heurekaCategoryDataFactory
+     * @param \Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryDataFactory $heurekaCategoryDataFactory
      */
     public function __construct(
         $heurekaCategoryFeedUrl,
-        protected readonly HeurekaCategoryDataFactoryInterface $heurekaCategoryDataFactory,
+        protected readonly HeurekaCategoryDataFactory $heurekaCategoryDataFactory,
     ) {
         $this->heurekaCategoryFeedUrl = $heurekaCategoryFeedUrl;
     }

diff --git a/src/Model/Product/HeurekaProductDomainDataFactory.php b/src/Model/Product/HeurekaProductDomainDataFactory.php
@@ -4,7 +4,7 @@
 
 namespace Shopsys\ProductFeed\HeurekaBundle\Model\Product;
 
-class HeurekaProductDomainDataFactory implements HeurekaProductDomainDataFactoryInterface
+class HeurekaProductDomainDataFactory
 {
     /**
      * @return \Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainData

diff --git a/src/Model/Product/HeurekaProductDomainDataFactoryInterface.php b/src/Model/Product/HeurekaProductDomainDataFactoryInterface.php
diff --git a/src/Resources/config/services.yaml b/src/Resources/config/services.yaml
@@ -28,12 +28,6 @@ services:
         tags:
             - { name: shopsys.feed, hours: '2', minutes: '0' }
 
-    Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryDataFactoryInterface:
-        alias: Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryDataFactory
-
     Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory\HeurekaCategoryDownloader:
         arguments:
             - '%shopsys.product_feed.heureka_bundle.heureka_category_feed_url%'
-
-    Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactoryInterface:
-        alias: Shopsys\ProductFeed\HeurekaBundle\Model\Product\HeurekaProductDomainDataFactory