Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

シグナリング notify の項目を追加する #217

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

zztkm
Copy link
Contributor

@zztkm zztkm commented Jan 8, 2025

  • [ADD] SignalingNotify に項目を追加する
    • 追加する項目
      • timestamp
      • spotlightNumber
      • failedConnectionId
      • currentState
      • previousState

This pull request includes changes to the SignalingNotify struct in the Sora/Signaling.swift file to add new properties and update the Codable conformance. Additionally, the CHANGES.md file has been updated to reflect these changes.

Changes to SignalingNotify struct:

  • Added new properties: timestamp, spotlightNumber, failedConnectionId, currentState, and previousState. [1] [2] [3]
  • Updated Codable conformance to include the new properties in the CodingKeys enum and the init(from decoder: Decoder) method. [1] [2] [3]

Documentation update:

  • Updated CHANGES.md to include the new properties added to SignalingNotify.

@zztkm zztkm self-assigned this Jan 8, 2025
@zztkm zztkm changed the title WIP: シグナリング notify の項目を追加する [WIP] シグナリング notify の項目を追加する Jan 8, 2025
@zztkm zztkm changed the title [WIP] シグナリング notify の項目を追加する シグナリング notify の項目を追加する Jan 8, 2025
@zztkm zztkm requested a review from torikizi January 8, 2025 09:20
Copy link
Contributor

@torikizi torikizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。
動作確認も大丈夫そうでした。

@zztkm zztkm merged commit 43fdbd0 into develop Jan 9, 2025
4 checks passed
@zztkm zztkm deleted the feature/update-signaling-notify branch January 9, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants