Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ドキュメントを最新化 #155

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

torikizi
Copy link
Contributor

  • 優先実装が可能な対応一覧を見直し
  • 既知の問題のタイトルを見直し
  • サンプルの名称を正しくする
  • examples の動作環境について記載を見直し

@torikizi torikizi requested a review from miosakuma January 20, 2025 09:26
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS の deployment_target は iOS 14 にあげてもよさそうです。

以下で定義されていますが、14 に上がっているはずです。

args.append(f"-DCMAKE_OSX_DEPLOYMENT_TARGET={webrtc_deps['IOS_DEPLOYMENT_TARGET']}")

参考
https://webrtc-review.googlesource.com/c/src/+/357741/2/tools_webrtc/ios/build_ios_libs.py

Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あとは大丈夫です、ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants