Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL のビルドのために libgl-dev のインストールを追加する #153

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

torikizi
Copy link
Contributor

SDL のビルド時に OpenGL がない場合、OpenGL 機能が無効化される仕様になっていたためインストールを追加


This pull request includes updates to the build workflow and documentation to ensure proper installation of the libgl-dev package, which is necessary for SDL builds.

Changes to build workflow:

Documentation updates:

  • CHANGES.md: Documented the addition of libgl-dev installation for SDL builds to prevent OpenGL-related issues during the build process.

@torikizi torikizi requested review from melpon and miosakuma January 16, 2025 07:17
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございました。
examples のビルドの直前で apt install した方がよいかなと考えましたが、install が一箇所に固まっている今の状態の方がわかりやすくてよいと思いました。

@@ -236,6 +236,9 @@ jobs:
# X11
sudo apt-get install libx11-dev libxext-dev

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

追加箇所に問題ないかを確認していただきたいです。
libgl-dev が必要なのは examples のみですが、インストール箇所をまとめるためにここへ追加しています。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants