Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert limit orders to new trade UI #8608

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

0xApotheosis
Copy link
Member

Description

Work in progress PR aimed at achieving the following:

  • Updates the Limit Order UI to use the new trade UI
  • Implements USDT allowance reset for limit orders

Issue (if applicable)

Closes #8561

Risk

Medium

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Limit order confirmation functionality, including allowance approvals and resets.

Testing

TODO

Engineering

TODO

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

TODO

Screenshots (if applicable)

TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update limit orders to use new approval flow
1 participant