-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new wallet flow for native #8597
Conversation
src/context/WalletProvider/NativeWallet/components/NativeSuccess.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: disable the already selected wallet, make it in a selected state
Suggestion: display the currently selected wallet name because it feels weird that the right content is not changing at all when clicking from one native wallet to another
Desktop test (this flag)
Mobile responsive test (this flag)
I tested the exact same flow on mobile (fuckdamn I forgot to record 😆 )
Without the flag
https://jam.dev/c/7399984e-5641-4c4e-ac7b-f94b8f747d84
From a functional point of view, looks perfect
Description
Brings in native over the new wallet flow.
Note, this does not add mobile vaults support, see #8607 - deployed in gome with the flag off for regression test
Issue (if applicable)
Risk
Low/Medium. Same as previously, code paths for develop/prod are not touched, except one re: not rendering the modal altogether unless it's opened.
Testing
Engineering
With the
REACT_APP_FEATURE_NEW_WALLET_FLOW=true
flag onFlag off
Operations
🏁 My feature is behind a flag and doesn't require operations testing (yet)
Effectively a noop PR, but given there is a one-line change in current wallet flow, test native e2e. As a wise man once said "any code change is a change".
Also regression test that mobile app is still happy with the flag off (switch envs to gome in mobile app)
Screenshots (if applicable)
Flag on
https://jam.dev/c/bf3757e3-9699-483a-b483-7cb12ad83a29
Flag off - regression test
https://jam.dev/c/c329c7b2-8dcf-4427-a7d7-88a5776f6493