Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new wallet flow for native #8597

Merged
merged 37 commits into from
Jan 17, 2025
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 16, 2025

Description

Brings in native over the new wallet flow.

Note, this does not add mobile vaults support, see #8607 - deployed in gome with the flag off for regression test

TODO:

- [x] ShapeShift native wallet as empty state CTA of sorts
- [x] Import keystore 
- [x] Import seed 
- [x] Create 
- [x] List and load
- [x] fix selected styles
- [x] fix reopen after loading a wallet insta-loads to success and closes modal
- [x] tackle IIAFE OCD TODO
- [x] test mobile (browser) and deploy on gome for mobile app regression test
- [x] confirmed with beard only the intro needs a new design, as well as the import/create view (same as in prod, minus the "Saved Wallets" ~~new steps design? check with product~~

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

Low/Medium. Same as previously, code paths for develop/prod are not touched, except one re: not rendering the modal altogether unless it's opened.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Engineering

With the REACT_APP_FEATURE_NEW_WALLET_FLOW=true flag on

  • Test native e2e: import seed, import keystore, create, list, load
  • Switching between saved wallets should be happy
  • Switching between EVM installed and savec wallets should be happy

Flag off

  • Regression test native flow e2e
  • Mobile app is still happy with the flag off (switch envs to gome in mobile app)

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

  • Effectively a noop PR, but given there is a one-line change in current wallet flow, test native e2e. As a wise man once said "any code change is a change".

  • Also regression test that mobile app is still happy with the flag off (switch envs to gome in mobile app)

Screenshots (if applicable)

Flag on

https://jam.dev/c/bf3757e3-9699-483a-b483-7cb12ad83a29

Flag off - regression test

https://jam.dev/c/c329c7b2-8dcf-4427-a7d7-88a5776f6493

@gomesalexandre gomesalexandre changed the title [skip ci] wip: new wallet flow for native feat: new wallet flow for native Jan 16, 2025
@gomesalexandre gomesalexandre marked this pull request as ready for review January 16, 2025 23:08
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 16, 2025 23:08
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: disable the already selected wallet, make it in a selected state
image

Suggestion: display the currently selected wallet name because it feels weird that the right content is not changing at all when clicking from one native wallet to another
image

Desktop test (this flag)

image

Mobile responsive test (this flag)

I tested the exact same flow on mobile (fuckdamn I forgot to record 😆 )

Without the flag

https://jam.dev/c/7399984e-5641-4c4e-ac7b-f94b8f747d84

From a functional point of view, looks perfect

MM route

image image

@gomesalexandre gomesalexandre merged commit 63b3458 into develop Jan 17, 2025
6 checks passed
@gomesalexandre gomesalexandre deleted the feat_new_wallet_flow_native branch January 17, 2025 13:59
gomesalexandre added a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New wallet flow - Native
2 participants