-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle long asset names in send input #7751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, and while name does ellipse now, there are still issues re: overflowing array as well as symbol still rugging the send display:
https://jam.dev/c/3723bfe2-5d04-472d-9fbe-1d7ff71e024c
See arrow placement/symbol rugging "Enter Amount" with long symbols vs. smolish ones:
c2ef72b
to
bfc5377
Compare
Well spotted, changed approach to use css variables and looking much better: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixes text overflow of asset label in send input.
Adds a ellipsis for overflow with tooltip.'
Opted to use
trimWithEndEllipsis
intead of CSS ellipsis so we can predictably and simly detect an overflow render the tooltip accordingly.Issue (if applicable)
closes #7720
Risk
Low risk - display concern only.
Testing
Check normal length asset names are rendered correctly without a tooltip.
Check very long asset names are truncated with an ellipsis and have a tooltip with the full asset name.
Engineering
Operations
Screenshots (if applicable)
Screen.Recording.2024-09-16.at.2.50.27.PM.mov