-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: augment runtime LP tokens metadata from Portals #7675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
changed the title
[skip ci] wip: augment runtime LP tokens metadata from Portals
feat: augment runtime LP tokens metadata from Portals
Sep 3, 2024
gomesalexandre
commented
Sep 3, 2024
kaladinlight
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rationale: While attempting to tackle #730, I noticed Zapper was already giving us the LP tokens data we need, and all we needed was to route using
isPool
criteria.Easy? As it usually goes, not exactly. After debugging things out and accomodating the Zapper parser with its parsing, I noticed the routing still wasn't working for some assets, but was working for others. The reason for that is if we are missing an asset in
generatedAssetData.json
(which we may), but have it in the portfolio, we'll leverage unchained to upsert its minimal version - minimal in this context meaning on-chain symbol, name, etc. No image, nothing fancy.This PR ensures we leverage Portals data for said assets whenever possible, in preparation for the actual routing in a follow-up.
Issue (if applicable)
Risk
Testing
This one assumes you have some LP tokens which are not present in the current Portals assets in the store. I tested this myself with Trader Joe BNB/AVAX i.e
0xeb8eb6300c53c3addbb7382ff6c6fbc4165b0742
generatedAssetData.json
Engineering
Operations
Screenshots (if applicable)
Tested against develop (right):