Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thorchain-1 support #7510

Merged
merged 12 commits into from
Sep 9, 2024
Merged

feat: thorchain-1 support #7510

merged 12 commits into from
Sep 9, 2024

Conversation

kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Aug 7, 2024

Description

** DO NOT MERGE UNTIL THORCHAIN HARD FORK OCCURS**

  • update thorchain chain id to thorchain-1
  • add new env var for thorchain-mainnet-v1 http url
  • generate new thorchain v1 api client
  • add new getTxHistoryV1 chain adapters method that will query tx history for thorchain-mainnet-v1
  • update txHistorySlice to fetch tx history from both thorchain-1 (first) and thorchain-mainnet-v1 (second)

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #7406

Risk

High Risk PRs Require 2 approvals

High

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

  • Ensure accurate thorchain balance
  • Ensure full tx history (all chains)
  • Ensure tx parsing is still accurate and displaying expected information
  • Ensure send and all thorchain defi actions work for thorchain txs
  • Ensure websockets are working and pick up new thorchain txs
  • Ensure thorchain defi metadata is accurate from midgard
  • Ensure tx status detection is working as expected for thorchain swaps and defi actions

Pretty much we want a full regression test of all things thorchain post fork and then general regression test for tx history for all chains.

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

@kaladinlight kaladinlight changed the title feat: thorchain v2 support feat: thorchain-1 support Sep 3, 2024
@kaladinlight kaladinlight marked this pull request as ready for review September 6, 2024 22:28
@kaladinlight kaladinlight requested a review from a team as a code owner September 6, 2024 22:28
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaladinlight happy to get this guy in as most things are now unrugged 🎉 except for RUNEPool (may or may not be an easy fix on the web side), snaps invalid signatures (bit trickier but unrelated) and LP withdraws (not happy on-chain, but broadcasted without any issue). Baller work!

  • Didn't spot any thorchain-mainnet-v1 reference except one expected one for legacy support
  • Sanity asset regen pass looks happy
    https://jam.dev/c/a4ac7f6a-5007-4de5-a901-70b17f5b6c04
  • RUNE account/balance is happy
    image
  • RUNE Tx history is happy
    image
    image
  • Tested RUNEPool with RUNEPool flag monkey patched to true locally - RUNEPool doesn't load
  • LP deposits/withdraws of RUNE Txs are happy
  • RUNE self-sends are happy

See e2e test of swapper/LP/RUNEPool/self-sends in https://jam.dev/c/9ab4764f-b5a4-4f73-b503-18b3a0691a28

@kaladinlight kaladinlight merged commit 0e7c273 into develop Sep 9, 2024
3 checks passed
@kaladinlight kaladinlight deleted the thorchain-v2 branch September 9, 2024 16:21
gomesalexandre pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thorchain hardfork preparation
3 participants