-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: thorchain-1 support #7510
Conversation
packages/chain-adapters/src/cosmossdk/thorchain/ThorchainChainAdapter.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaladinlight happy to get this guy in as most things are now unrugged 🎉 except for RUNEPool (may or may not be an easy fix on the web side), snaps invalid signatures (bit trickier but unrelated) and LP withdraws (not happy on-chain, but broadcasted without any issue). Baller work!
- Didn't spot any
thorchain-mainnet-v1
reference except one expected one for legacy support - Sanity asset regen pass looks happy
https://jam.dev/c/a4ac7f6a-5007-4de5-a901-70b17f5b6c04 - RUNE account/balance is happy
- RUNE Tx history is happy
- Tested RUNEPool with RUNEPool flag monkey patched to true locally - RUNEPool doesn't load
- LP deposits/withdraws of RUNE Txs are happy
- RUNE self-sends are happy
See e2e test of swapper/LP/RUNEPool/self-sends in https://jam.dev/c/9ab4764f-b5a4-4f73-b503-18b3a0691a28
Description
** DO NOT MERGE UNTIL THORCHAIN HARD FORK OCCURS**
thorchain-1
thorchain-mainnet-v1
http urlgetTxHistoryV1
chain adapters method that will query tx history forthorchain-mainnet-v1
txHistorySlice
to fetch tx history from boththorchain-1
(first) andthorchain-mainnet-v1
(second)Pull Request Type
Issue (if applicable)
closes #7406
Risk
High
Testing
Pretty much we want a full regression test of all things thorchain post fork and then general regression test for tx history for all chains.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)