small cleanup

shamanec · Jul 24, 2023 · 8aacebd · 8aacebd
1 parent 63601d9
commit 8aacebd
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/...deproj/project.xcworkspace/xcuserdata/shamanec.xcuserdatad/UserInterfaceState.xcuserstate b/...deproj/project.xcworkspace/xcuserdata/shamanec.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/xcuitest-sample-projUITests/Extensions/XCUIApplication+Extensions.swift b/xcuitest-sample-projUITests/Extensions/XCUIApplication+Extensions.swift
@@ -8,7 +8,6 @@
 import XCTest
 
 extension XCUIApplication {
-
     /// Tap the zero coordinate of the app, useful for closing keyboards or triggering UIApplicationMonitor
     func tapZero() { coordinate(withNormalizedOffset: .zero).tap() }
 }
diff --git a/xcuitest-sample-projUITests/Extensions/XCUIElementQuery+Extensions.swift b/xcuitest-sample-projUITests/Extensions/XCUIElementQuery+Extensions.swift
@@ -14,7 +14,7 @@ extension XCUIElementQuery {
     /// Check if the XCUIElementQuery has no elements
     var isEmpty: Bool { count == 0 }
 
-    // MARK: Return element by predicate methods
+    // MARK: - Return element by predicate methods
     /// Get element where the label exactly matches the provided string
     func element(withLabelMatching text: String) -> XCUIElement {
         return element(matching: NSPredicate(format: "label == %@", text))

diff --git a/xcuitest-sample-projUITests/Foundations/BasePage.swift b/xcuitest-sample-projUITests/Foundations/BasePage.swift
@@ -47,7 +47,7 @@ class BasePage {
         self.setReflectionIdleHack(false)
     }
 
-    // MARK: Utility methods
+    // MARK: - Utility methods
     func keyboardVisible() -> Bool {
         let startTime = NSDate().timeIntervalSince1970
         while (NSDate().timeIntervalSince1970 - startTime) < TestConstants.Timeout.medium {
@@ -82,7 +82,7 @@ class BasePage {
         app.buttons["OK"].tap()
     }
 
-    func tabCancel() {
+    func tapCancel() {
         app.buttons["Cancel"].tap()
     }
 }
diff --git a/xcuitest-sample-projUITests/SampleAppUITests.swift b/xcuitest-sample-projUITests/SampleAppUITests.swift
@@ -34,6 +34,7 @@ final class SampleAppUITests: BaseTest {
         let firstPage = FirstPage(app: getApp())
         let text = firstPage.carouselItems.lastMatch.label
         print("The label of the last matching element in the carousel is `\(text)`")
+        XCTAssertFalse(text == "Item 1")
     }
 
     func testElementDisappearsSameScreen() {
@@ -59,7 +60,7 @@ final class SampleAppUITests: BaseTest {
         let elements = secondPage.loadingElements
         // Wait for 10 seconds to have 5 elements, should pass
         Elements.waitUntilTableFilled(elements, 5, TestConstants.Timeout.medium)
-        // Wait 5 more seconds to have 6 elements, should fail because only 5 in total will be loaded
+        // Should fail because only 5 in total will be loaded
         Elements.waitUntilTableFilled(elements, 6, TestConstants.Timeout.short)
     }