Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libSceHttp2 Stubs #2139

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Conversation

StevenMiller123
Copy link
Contributor

This PR adds auto-generated stubs for libSceHttp2, and makes sceHttp2Init return a positive value.

Parameter names for sceHttp2Init are based on the names used by fpPS4, with names altered to better suit our coding guidelines. The dummy return I used is based on similar code used in our libSceSsl, libSceSsl2, and libSceHttp libraries.

This fixes an exception seen in updated versions of Cyberpunk 2077.

Needed for updated versions of Cyberpunk 2077.

Parameters are based on fpPS4, while the stub itself is based on similar stubs in our other networking libraries.
I guess the line length calculations in the moduleGenerator are still not perfect?
int PS4_SYSV_ABI sceHttp2GetMemoryPoolStats();
int PS4_SYSV_ABI sceHttp2GetResponseContentLength();
int PS4_SYSV_ABI sceHttp2GetStatusCode();
int PS4_SYSV_ABI sceHttp2Init(int net_id, int ssl_id, size_t pool_size, int max_requests);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use our custom types, same thing on the TU. No need to change it for the other stubs

@georgemoralis georgemoralis merged commit c6ab149 into shadps4-emu:main Jan 12, 2025
11 checks passed
@StevenMiller123 StevenMiller123 deleted the libSceHttp2-stubs branch January 12, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants