apacheGH-11172: remove WindowsDirectory and native subproject. (apach…

…e#11774)
sgup432 · Sep 15, 2022 · 9acc653 · 9acc653
1 parent 0587844
commit 9acc653
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 566 deletions.
diff --git a/build.gradle b/build.gradle
@@ -158,9 +158,6 @@ apply from: file('gradle/generation/antlr.gradle')
 
 apply from: file('gradle/datasets/external-datasets.gradle')
 
-// Shared configuration of subprojects containing native code.
-apply from: file('gradle/native/disable-native.gradle')
-
 // Additional development aids.
 apply from: file('gradle/testing/per-project-summary.gradle')
 apply from: file('gradle/testing/slowest-tests-at-end.gradle')

diff --git a/gradle/native/disable-native.gradle b/gradle/native/disable-native.gradle
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
@@ -90,6 +90,9 @@ API Changes
 * GITHUB#11742: MatchingFacetSetsCounts#getTopChildren now properly returns "top" children instead
   of all children. (Greg Miller)
 
+* GITHUB#11772: Removed native subproject and WindowsDirectory implementation from lucene.misc. Recommendation:
+  use MMapDirectory implementation on Windows. (Robert Muir, Uwe Schindler, Dawid Weiss)
+
 Bug Fixes
 ---------------------
 * GITHUB#11726: Indexing term vectors on large documents could fail due to

diff --git a/lucene/misc/build.gradle b/lucene/misc/build.gradle
@@ -22,6 +22,4 @@ description = 'Index tools and other miscellaneous code'
 dependencies {
   moduleApi project(':lucene:core')
   moduleTestImplementation project(':lucene:test-framework')
-
-  nativeDeps project(":lucene:misc:native")
 }
diff --git a/lucene/misc/native/build.gradle b/lucene/misc/native/build.gradle
diff --git a/lucene/misc/native/src/main/windows/WindowsDirectory.cpp b/lucene/misc/native/src/main/windows/WindowsDirectory.cpp