Unpin numpy #283
Merged
Unpin numpy #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromekelleher
force-pushed
the
numpy2
branch
3 times, most recently
from
2f71f1a to
79848a4
Compare
jeromekelleher
force-pushed
the
numpy2
branch
from
79848a4 to
4dd205e
Compare
|
@tomwhite I think this should give us long-term back-and-forth compatibility with numpy 1.26 and >=2 🤞 What do you think? |
Closed
tomwhite
approved these changes
Oct 28, 2024
I did check it manually, but ran out of enthusiasm in terms of coming up with a test case to formally check this. I figure it's a rare enough corner case that we can not worry too much about it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.