Saving more space during construction. #213
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to PR #211 .
It replace another relabeling data structure and replaces it with a binary search on the accumulated sizes of the sequences. The created index doesn't change (creates identical binary).
Memory: for 20GB input and sampling Rate of 5, I am expecting to additionally save 32GB of memory during construction.
Runtime: This is very hard to predict. Purely theoretically we replace
O(n)
withO(n * log(m))
, where m is the number of sequences. In my test (386MB input) I have seen a runtime reduction of ~10%.Update: There was another structure that I could reuse, which would be an additional 32GB of savings.
This should lead in a total of 64GB less memory...With this lambda3 might be the same in memory usage to lambda2