Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading script from file and evaluate as devtools for chromedp #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Splinter0
Copy link

Hi there!

First of all, love the tool and are an avid user.

I was trying to work with the --javascript-file and I noticed it would just not run for me, it seems like the way opts were handled the version copied to the runner was resetting the Scan.JavaScript to "", leaving it with nothing to run.

Additionally I noticed that when working with more complex js I would get a lot of errors, however using EvaluateAsDevTools instead of Evaluate worked like a charm in chromedp.

Another good addition could be to add the return of the js being executed to the outputs. Also I am not sure if the same problem for gorod was present, might want to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant