Fix loading script from file and evaluate as devtools for chromedp #269
+38
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
First of all, love the tool and are an avid user.
I was trying to work with the
--javascript-file
and I noticed it would just not run for me, it seems like the wayopts
were handled the version copied to the runner was resetting theScan.JavaScript
to""
, leaving it with nothing to run.Additionally I noticed that when working with more complex js I would get a lot of errors, however using
EvaluateAsDevTools
instead ofEvaluate
worked like a charm in chromedp.Another good addition could be to add the return of the js being executed to the outputs. Also I am not sure if the same problem for
gorod
was present, might want to investigate.