Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deposit and withdraw with lulo #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhourunlai
Copy link
Contributor

@zhourunlai zhourunlai commented Jan 2, 2025

Pull Request Description

Related Issue

Fixes # (issue number)

Changes Made

This PR adds the following changes:

  • deposit and withdraw with lulo

Implementation Details

doc api: https://docs.lulo.fi/api-docs

Transaction executed by agent

Example transaction:

  1. Lend: https://solscan.io/tx/4931BjyRpZstvvppSQrGiPR3aUko8jVadWk2UMXEwGvNh7uebNPv9KKAucezVc93XJ8NaWqeYA4iA49fzsNrtoVC
  2. Withdraw:
    https://solscan.io/tx/4JTjkAWG8ax19XXvQKyMiWcP5Z3j8SGdDuZEjBENMZJD29auHSyjgZuxNYqJWhBDqEEbG3eoFV5JKz9jDhsxUAkT

Prompt Used

Lend 0.01 SOL to earn yield on Lulo

Withdraw 0.01 SOL with lulo

Additional Notes

image

Checklist

  • I have tested these changes locally
  • I have updated the documentation
  • I have added a transaction link
  • I have added the prompt used to test it

@zhourunlai zhourunlai force-pushed the deposit_and_withdraw_with_lulo branch from faae4d8 to e186960 Compare January 4, 2025 05:25
@arihantbansal
Copy link
Member

We already have deposit with Lulo https://github.com/sendaifun/solana-agent-kit/blob/main/src/tools/lend.ts
Please modify that instead of making a new tool.

@zhourunlai zhourunlai force-pushed the deposit_and_withdraw_with_lulo branch 2 times, most recently from c1b0239 to cc00661 Compare January 4, 2025 14:40
@zhourunlai
Copy link
Contributor Author

We already have deposit with Lulo https://github.com/sendaifun/solana-agent-kit/blob/main/src/tools/lend.ts Please modify that instead of making a new tool.

@arihantbansal modified it to support other tokens and add the withdraw tool.

@zhourunlai zhourunlai force-pushed the deposit_and_withdraw_with_lulo branch 2 times, most recently from 29e34ea to 67d44e1 Compare January 5, 2025 12:10
@zhourunlai
Copy link
Contributor Author

@arihantbansal just use the prompt to test the action of lending and withdrawing.

@thearyanag
Copy link
Member

hey @zhourunlai - pardon the wait

this looks good to merge, before that can you do a couple of things pls

  1. For lending, let's use blink only - making that action independent of the api key
  2. For rest, can use the api but pls pass the api key in config object present in the agent class

do share your tg handle also

@zhourunlai zhourunlai force-pushed the deposit_and_withdraw_with_lulo branch 3 times, most recently from e9466ed to e486ff3 Compare January 10, 2025 07:58
@zhourunlai zhourunlai force-pushed the deposit_and_withdraw_with_lulo branch from e486ff3 to bc6b4b5 Compare January 10, 2025 08:02
@zhourunlai
Copy link
Contributor Author

zhourunlai commented Jan 10, 2025

hey @zhourunlai - pardon the wait

this looks good to merge, before that can you do a couple of things pls

  1. For lending, let's use blink only - making that action independent of the api key
  2. For rest, can use the api but pls pass the api key in config object present in the agent class

do share your tg handle also

@thearyanag

  1. I have recovered the blink for lending that no api key is needed.
  2. I have added the Independent action for lulo.

and my tg handle: @xiaorun0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants