Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End 2 end CANCEL Reason (and other additional CANCEL headers) #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThomasSevestre
Copy link
Contributor

This is a solution to #164

Please, be aware...

I've not tested the PR on master but it is working on an older version of sems.
I've used this with SBC application only.
It would be better to pass Reason header only.

@juha-h
Copy link
Contributor

juha-h commented Dec 17, 2020

Is relaying of CANCEL headers configurable in sbc profile?

@ThomasSevestre
Copy link
Contributor Author

Not in this PR.

First it could be a good idea to make sure this is triggered only in SBC module, we need to override onCancel in CallLeg (see here)

This looks simple, I can do it.

CallLeg does not have direct access to profiles, it requires more work to make this configurable. Relaying CANCEL Reason header looks like something that should be done by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants