Only call onChange and onComplete in onImageLoaded if the crop is val…

…id (has a width and height)
sekoyo · Oct 25, 2018 · 7ac1c34 · 7ac1c34 · mweibel · Nov 1, 2018
1 parent 80a0f07
commit 7ac1c34
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/dist/ReactCrop.js b/dist/ReactCrop.js
@@ -158,7 +158,7 @@ function clamp(num, min, max) {
 }
 
 function isCropValid(crop) {
-  return crop && crop.width && crop.height;
+  return crop && crop.width && crop.height && !isNaN(crop.width) && !isNaN(crop.height);
 }
 
 function inverseOrd(ord) {
@@ -554,7 +554,7 @@ var ReactCrop = function (_PureComponent) {
 
       // Generation of clientside crops will happen here so for convenience it's best to
       // do it after an image ref has been saved from onImageLoaded.
-      if (resolvedCrop) {
+      if (resolvedCrop && isCropValid(resolvedCrop)) {
         this.props.onChange(resolvedCrop, pixelCrop);
         this.props.onComplete(resolvedCrop, pixelCrop);
       }