Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary service naming scheme #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Sep 6, 2023

What was the reason of adding this? Is it OK to take this out?

@seime
Copy link
Owner

seime commented Sep 6, 2023

@jimtng this is a workaround for openhab/openhab-core#3753

@jimtng
Copy link
Contributor Author

jimtng commented Sep 7, 2023

IMO it would still be better to remove the additional name and solve the linked issue some other way, because people who use UI would probably just accept the suggested naming anyway, thus back to the original problem.

I don't use UI discovery, so I'm not personally too invested in this. I only used it to try things out and noticed this. Feel free to close this if you think the naming should remain.

@seime
Copy link
Owner

seime commented Sep 7, 2023

Unfortunately the discovery runs in the background anyhow, and unless you are using thing files yes you will have trouble if you do not remove this part.

Personally I use files so I am not affected, but it was reported here as #1 . Would prefer to have this fixed in core, but the discussion with the maintainers stalled

@amandel
Copy link
Contributor

amandel commented Dec 5, 2023

What about adding a additional configuration option do store either the discovered dns name or a manually entered dns/ip? This would allow the manual setting to survive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants