Skip to content

Commit

Permalink
Ditch ts-node - I'm pretty sure sku lint would typecheck it?
Browse files Browse the repository at this point in the history
  • Loading branch information
AaronMoat committed Dec 16, 2024
1 parent d7297c6 commit 206679b
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 23 deletions.
4 changes: 1 addition & 3 deletions fe/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"react-router-dom": "6.22.3",
"scoobie": "18.1.1",
"storybook": "8.4.7",
"ts-node": "10.9.2",
"use-query-params": "2.2.1",
"webpack-merge": "6.0.1"
},
Expand Down Expand Up @@ -68,8 +67,7 @@
"build": "sku build",
"build-storybook": "storybook build --output-dir dist-storybook",
"format": "sku format",
"lint": "sku lint && pnpm -s lint:codegen",
"lint:codegen": "ts-node lib/types/seekApi.typeDefs.ts",
"lint": "sku lint",
"serve": "sku serve",
"start": "sku start",
"start-storybook": "storybook dev",
Expand Down
7 changes: 0 additions & 7 deletions fe/sku.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,6 @@ const config: SkuConfig = {
// under `browser` in package.json
customConditions: ['browser'],
},
// Override the compiler options when running ts-node
// to handling linting of typedefs
'ts-node': {
compilerOptions: {
module: 'nodenext',
},
},
include: ['**/*', '.storybook/*'],
}),
};
Expand Down
36 changes: 23 additions & 13 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 206679b

Please sign in to comment.