Chore: improved code coverage #44
Open
+631
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mariocao
reviewed
Jan 10, 2025
Comment on lines
+27
to
33
| // Doesn't exist for Singlepass compiler | ||
| // /// The ID of the WASM file, loads from cache | ||
| // Id(String), | ||
| // Unlikely to be used for tallyvm? | ||
| // /// The path on disk of the WASM file | ||
| // Path(String), | ||
| /// The bytes of the binary |
There was a problem hiding this comment.
Should we check with @FranklinWaller why we had this and we don't use it anymore? :)
mariocao
reviewed
Jan 10, 2025
Comment on lines
+22
to
+54
| // not used with singlepass compiler | ||
| // pub fn wasm_cache_store<ID: ToString, T: AsRef<[u8]>>( | ||
| // sedad_home: &Path, | ||
| // store: &Store, | ||
| // id: ID, | ||
| // wasm_binary: T, | ||
| // ) -> Result<Module> { | ||
| // let wasm_cache_path = create_cache_path(sedad_home, id)?; | ||
| // let module = Module::new(&store, &wasm_binary)?; | ||
|
|
||
| // let mut file = File::create(wasm_cache_path)?; | ||
| // let buffer = module.serialize()?; | ||
| // file.write_all(&buffer)?; | ||
|
|
||
| // Ok(module) | ||
| // } | ||
|
|
||
| // not used with singlepass compiler | ||
| // pub fn wasm_cache_load<ID: ToString>(sedad_home: &Path, store: &Store, id: ID) -> Result<Module> { | ||
| // let wasm_cache_path = create_cache_path(sedad_home, id)?; | ||
|
|
||
| // unsafe { | ||
| // let ret = Module::deserialize_from_file(&store, wasm_cache_path.clone()); | ||
|
|
||
| // if ret.is_err() { | ||
| // // If an error occurs while deserializing then we can not trust it anymore | ||
| // // so delete the cache file | ||
| // let _ = std::fs::remove_file(wasm_cache_path); | ||
| // } | ||
|
|
||
| // Ok(ret?) | ||
| // } | ||
| // } |
There was a problem hiding this comment.
After checking it, if we don't use it and we don't intent to use it in the future, we could remove it, right?
There was a problem hiding this comment.
Yea, they are used on the overlay side where this was taken. I didn't remove it because I wasn't sure if we'd ever swap off singlepass. But I suppose it's safe to remove since we could always copy it back from the overlay?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the upcoming code audit.
Explanation of Changes
Testing
They all pass.
Related PRs and Issues
N/A