Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode to close dome using overcurrent only #33

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

albireox
Copy link
Member

@albireox albireox commented Jan 7, 2025

No description provided.

@albireox albireox requested a review from mmingyeong as a code owner January 7, 2025 03:42
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.7%. Comparing base (cab8446) to head (66abc2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/lvmecp/dome.py 78.6% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #33     +/-   ##
=======================================
- Coverage   81.8%   81.7%   -0.0%     
=======================================
  Files         19      19             
  Lines        925     937     +12     
  Branches     134     137      +3     
=======================================
+ Hits         756     765      +9     
- Misses       103     104      +1     
- Partials      66      68      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albireox albireox merged commit 72ae8bc into main Jan 7, 2025
7 checks passed
@albireox albireox deleted the albireox-dome-mode branch January 7, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant