Add --stderr option
#454
Merged
Add --stderr option
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmelz
commented
Oct 28, 2023
Comment on lines
+41
to
+60
| context 'when a logger is not passed' do | ||
| let(:logger) { nil } | ||
|
|
||
| it 'sets a default logger that writes to stdout' do | ||
| $stdout = StringIO.new | ||
| subject | ||
| expect(cli.send(:log).instance_variable_get(:'@out')).to eq($stdout) | ||
| end | ||
| end | ||
|
|
||
| context 'when passed the --stderr flag' do | ||
| let(:logger) { nil } | ||
| let(:args) { %w[--stderr] } | ||
|
|
||
| it 'sets a logger that writes to stderr' do | ||
| $stderr = StringIO.new | ||
| subject | ||
| expect(cli.send(:log).instance_variable_get(:'@out')).to eq($stderr) | ||
| end | ||
| end |
There was a problem hiding this comment.
These are preeeetty gross, but they're as direct as I could make them without exposing parts of CLI and Logger that don't need to be exposed. Open to other ideas if anyone has any.
The $stdout/err = StringIO.new keeps these test runs from cluttering up the rspec output.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @MaxLap on #452
This option can stand on its own and is pretty straightforward (just need to point the logger to
$stderrI believe), so I figured I would implement it before I work out--stdin.