Skip to content

Commit

Permalink
Enable rubocop rules this project is compliant with (#537)
Browse files Browse the repository at this point in the history
**What**

Enable rubocop rules this project is compliant with

- `Bundler/OrderedGems`
- `Style/CollectionMethods`
- `Style/FormatString`
- `Naming/FileName`
- `Style/SingleLineBlockParams`
- `Style/TrivialAccessors`

**Why**

Since we are compliant with these rules it feels a bit weird to have them disabled in the
`rubocop.yml` as we either are following the expectations intentionally and thus probably good to
lock down, or the lints aren't ones that are relevant to this project if they have no
issues a decade in.
  • Loading branch information
maddieholtzer authored Jan 3, 2025
1 parent 4b6a958 commit ef9dbbe
Showing 1 changed file with 0 additions and 24 deletions.
24 changes: 0 additions & 24 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,10 @@ AllCops:
Lint/AssignmentInCondition:
Enabled: false

Bundler/OrderedGems:
Enabled: false

# Enforcing this results in a lot of unnecessary indentation.
Style/ClassAndModuleChildren:
Enabled: false

Style/CollectionMethods:
Enabled: false

Style/Documentation:
Exclude:
- 'spec/**/*'
Expand All @@ -29,16 +23,6 @@ Style/Documentation:
Layout/DotPosition:
EnforcedStyle: leading

Style/FormatString:
Enabled: false

Naming/FileName:
Exclude:
- 'bin/haml-lint'
- 'Gemfile'
- 'Rakefile'
- '*.gemspec'

Style/GuardClause:
Enabled: false

Expand Down Expand Up @@ -107,11 +91,6 @@ Naming/PredicateName:
Style/SignalException:
Enabled: false

# Forcing a particular name (e.g. |a, e|) for inject methods prevents you from
# choosing intention-revealing names.
Style/SingleLineBlockParams:
Enabled: false

Style/SpecialGlobalVars:
Enabled: false

Expand Down Expand Up @@ -139,8 +118,5 @@ Style/TrailingCommaInArrayLiteral:
Style/TrailingCommaInHashLiteral:
Enabled: false

Style/TrivialAccessors:
Enabled: false

Lint/Void:
Enabled: false

0 comments on commit ef9dbbe

Please sign in to comment.