Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace out-of-support CentOS distro with RHEL9 for Manager tests on Azure #9631

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

mikliapko
Copy link
Contributor

@mikliapko mikliapko commented Dec 31, 2024

Closes #9630 #8226

The PR switches Manager tests on Azure from using centos-based to rhel-based.

Together with that, it implements a couple of different fixes to make such node setup possible (see list of commits for details).

Testing

  • Azure backup test - not related to PR failure, should be fixed here
  • Artifacts CentOS9 test

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Since CentOS deprecation, all the jobs should be switched from using it.
The only job in Manager tests that still uses CentOS is job for Azure.

The change replaces this CentOS7 image with RHEL9 and increases the root
disk size for monitor node to make new image workable.
- Updated the `yum_repos` method to include the EPEL 9 repo config;
- Updated the GPG key URL for EPEL 9.
Temporary workaround for docker installation on RHEL9 distro
because of the issue (1).

In provided fix docker packages are installed manually for repo,
hardcoding the OS version ($releasever) to specific value in
repo file /etc/yum.repos.d/docker-ce.repo.

After issue resolution, we can return the previous approach with
installation script.

refs:
#1: moby/moby#49169
Firewall should be disabled for RHEL-like distributions. Otherwise, it
blocks incoming requests to 3000 monitoring node (1).

The same operation has been already implemented for db nodes setup and
only refactored here.

refs:
#1: scylladb#9630
@mikliapko mikliapko self-assigned this Dec 31, 2024
@mikliapko
Copy link
Contributor Author

@fruch I made some changes around firewall disabling for db nodes.
Please, let me know which tests to run to verify I've not introduced any regression.

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch
Copy link
Contributor

fruch commented Dec 31, 2024

@fruch I made some changes around firewall disabling for db nodes.
Please, let me know which tests to run to verify I've not introduced any regression.

I think one of the redhat based artifact tests should be enough

@mikliapko
Copy link
Contributor Author

@fruch I made some changes around firewall disabling for db nodes.
Please, let me know which tests to run to verify I've not introduced any regression.

I think one of the redhat based artifact tests should be enough

Triggered artifacts test for CentOS9 - passed.

@mikliapko mikliapko added the backport/none Backport is not required label Dec 31, 2024
@mikliapko mikliapko marked this pull request as ready for review December 31, 2024 18:29
@mikliapko mikliapko requested a review from rayakurl as a code owner December 31, 2024 18:29
@fruch fruch merged commit 4cc0b7f into scylladb:master Jan 2, 2025
9 checks passed
@mikliapko mikliapko deleted the fix-azure-job-for-manager branch January 3, 2025 11:39
mikliapko added a commit to mikliapko/scylla-cluster-tests that referenced this pull request Jan 3, 2025
Changes:
- Removed scylla version hardcode for Azure job. The image defined in
azure_image_db contains Scylla 5.2.1 which outdated. Moreover, there
are no restrictions with passing scylla_version directly.
- Renamed jenkinsfile to address recent move from Centos-based image
for Azure jobs to RHEL-based (1).

refs:
#1: scylladb#9631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required promoted-to-master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set up monitoring node based on RHEL 9.5 image
3 participants