Skip to content

Commit

Permalink
fix(manager): drop error message check for enospc restore test
Browse files Browse the repository at this point in the history
Error message Manager returns for enospc scenario has been changed to
more generic one (#1). So, it doesn't make much sense to verify it.

Moreover, there is a plan to fix check free disk space behaviour and
the whole test will probably require rework to be done (#2).

refs:
#1 - scylladb/scylla-manager#4087
#2 - scylladb/scylla-manager#4184
  • Loading branch information
mikliapko committed Dec 20, 2024
1 parent bb016d1 commit 11a4ab4
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions mgmt_cli_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
from sdcm.nemesis import MgmtRepair
from sdcm.utils.adaptive_timeouts import adaptive_timeout, Operations
from sdcm.utils.common import reach_enospc_on_node, clean_enospc_on_node
from sdcm.utils.issues import SkipPerIssues
from sdcm.utils.loader_utils import LoaderUtilsMixin
from sdcm.utils.time_utils import ExecutionTimer
from sdcm.sct_events.system import InfoEvent
Expand Down Expand Up @@ -830,13 +829,6 @@ def test_enospc_before_restore(self):
assert final_status == TaskStatus.ERROR, \
f"The restore task is supposed to fail, since node {target_node} lacks the disk space to download" \
f"the snapshot files"

if not SkipPerIssues("scylladb/scylla-manager#4087", self.params):
full_progress_string = restore_task.progress_string(parse_table_res=False,
is_verify_errorless_result=True).stdout
assert "not enough disk space" in full_progress_string.lower(), \
f"The restore failed as expected when one of the nodes was out of disk space, " \
f"but with an ill fitting error message: {full_progress_string}"
finally:
clean_enospc_on_node(target_node=target_node, sleep_time=30)
self.log.info('finishing test_enospc_before_restore')
Expand Down

0 comments on commit 11a4ab4

Please sign in to comment.