-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammar fixes in sc.tl
docstrings
#3438
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3438 +/- ##
=======================================
Coverage 75.36% 75.36%
=======================================
Files 112 112
Lines 13219 13219
=======================================
Hits 9963 9963
Misses 3256 3256
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Please keep the docstring improvements and fixes coming. A few minor points. I am not a native speaker and am happy to be convinced that my comments are not valid.
Feel free to add a release note if you want this PR to be mentioned in the next release. Docstring improvements are important. |
Since I have a few modules to go maybe I could add a release note after I finish a few others (unless the release is super soon ). Then it would be something like |
Sure, fine with me. We can group them later. |
Been working with scanpy for a bit now and really appreciate all the work you're all doing. Noticed a few grammar mistakes in docstrings. If it's helpful I figured I could submit a couple PRs to fix up docstrings :) . As a demonstration this is just a quick rundown of the
tools
submodule. If this isn't desired just let me know.