Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): disallow AnnData(...) with non-csr{r,c} matrices/arrays #1829

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

ilan-gold
Copy link
Contributor

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (9120c4d) to head (4da83bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   86.06%   83.64%   -2.43%     
==========================================
  Files          40       40              
  Lines        6267     6268       +1     
==========================================
- Hits         5394     5243     -151     
- Misses        873     1025     +152     
Files with missing lines Coverage Δ
src/anndata/_core/storage.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

@flying-sheep
Copy link
Member

You think we should support bsr_array?

@ilan-gold
Copy link
Contributor Author

I think it could be worth opening an issue but we should probably fully close the linked issue first and then proceed with adding more.

@ilan-gold
Copy link
Contributor Author

I'd rather make things strict first and then relax rather than going from the current ambiguous state to ambiguous + another format.

tests/test_x.py Show resolved Hide resolved
@ilan-gold ilan-gold merged commit faec0f8 into main Jan 16, 2025
15 checks passed
@ilan-gold ilan-gold deleted the ig/no_non_csr_c_allowed branch January 16, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants