Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summer cleaning #115

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Summer cleaning #115

merged 1 commit into from
Oct 1, 2024

Conversation

Raveline
Copy link
Contributor

@Raveline Raveline commented Aug 30, 2024

While I'm working on this repo, I might as well do this.

  • Adds fourmolu to the CI;
  • Use the foumolu configuration used elsewhere in the company;
  • Apply it to the codebase;
  • Drop the "Setup.hs" file;

TODO:

  • Might be a good idea to discontinue support for older GHC version ?
  • Might be a good idea to merge all the open PRs, rebase & update this one before merging it.

@arybczak
Copy link
Collaborator

arybczak commented Sep 3, 2024

Might be a good idea to discontinue support for older GHC version ?

Yes please. Feel free to add 9.8 and 9.10 to the CI, drop 8.8. While we're at it, you can also enable ImportQualifiedPost and add -Werror=prepositive-qualified-module to ghc-options.

Let's merge this after all outstanding PRs are merged.

@Raveline Raveline merged commit d83fb05 into master Oct 1, 2024
9 checks passed
@Raveline Raveline deleted the modernise-ci branch October 1, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants