Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that sqlWhereEqualsAny is prefered to sqlWhereIn #108

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Document that sqlWhereEqualsAny is prefered to sqlWhereIn #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Database/PostgreSQL/PQTypes/SQL/Builder.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,9 @@ sqlWhereILike name value = sqlWhere $ name <+> "ILIKE" <?> value
sqlWhereEqualsAny :: (MonadState v m, SqlWhere v, Show a, ToSQL a) => SQL -> [a] -> m ()
sqlWhereEqualsAny name values = sqlWhere $ name <+> "= ANY(" <?> Array1 values <+> ")"

-- | Note: `sqlWhereIn` will unpack the array using `UNNEST`. Using a postgresql function in this way
-- will interfere with the planner. Use `sqlWhereEqualsAny` instead, except if you know that
-- `UNNEST` will optimize better.
sqlWhereIn :: (MonadState v m, SqlWhere v, Show a, ToSQL a) => SQL -> [a] -> m ()
sqlWhereIn name values = do
-- Unpack the array to give query optimizer more options.
Expand Down